Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide config used for clang-format #161

Open
leelavg opened this issue Nov 6, 2024 · 1 comment
Open

Please provide config used for clang-format #161

leelavg opened this issue Nov 6, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@leelavg
Copy link

leelavg commented Nov 6, 2024

Clang-format in all source code. (from changelog)

  • possible to provide the configuration used for clang-format? the default is resulting huge diff

Thanks for making the source available, I'm new to C & GUI as well, however a big thumbs-up for the documentation I was just changing some code to see what happens and w/o clang-format config I'm seeing huge diff.

Also, may I know what is the priority of removing hardcoded x11 to support wayland as well?

Removing the hardcoded env and adding 50 and 89 px (as you mentioned in another issue) for wayland (querying xdg_session_type) breaks X sizing and theme detection (maybe there are other fixes needed as well?).

Thanks again!

@frang75
Copy link
Owner

frang75 commented Nov 6, 2024

Hi @leelavg! Thanks for download and use NAppGUI.
.clang-format file has been added in this commit: 40356b8

Wayland support is related in this issue: #23
Unfortunately, this issue is not included in the roadmap for the current 1.5.0 release. I will try to add it for 1.5.1 (Feb-Mar 2025).

@frang75 frang75 self-assigned this Nov 6, 2024
@frang75 frang75 added the enhancement New feature or request label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants