Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: in create_lookup_table() and parameter lookup_year could something like latest be added? #1

Open
Lextuga007 opened this issue Nov 15, 2023 · 5 comments

Comments

@Lextuga007
Copy link

Without knowing the years needed it would be great to get the "latest", perhaps as default. I'm not sure how difficult this is with and API and querying it though so it might not be an enhancement that's possible currently.

@francisbarton
Copy link
Owner

I think it ought to retrieve the latest available by default, but it would be worth me doing some checks on this, and in any case making that default clearer in the documentation. Thanks Zoe.

@Lextuga007
Copy link
Author

Lextuga007 commented Nov 15, 2023

It does! I was in a rush and didn't read the documentation and it's very clear in the README 😄

To save face - could a message come up to say what year has been brought through? That could be good to note for the user and any report outputs?

@francisbarton
Copy link
Owner

francisbarton commented Nov 15, 2023

Like a ui_info() message output in the console, when run interactively? Presumably you wouldn't want that output within a script or if called within another package.

@francisbarton
Copy link
Owner

It could be worth doubling down on 'chatty' mode and making it give very informative output when that flag is turned on, I quite like that.

@Lextuga007
Copy link
Author

I'm thinking of the verbose message from {tidyverse} that use the {cli} package. The user couldn't necessarily use that information directly but it would at least be "surfaced" in the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants