From fa272caabdeab93cc0d686ce583da778fd87c24a Mon Sep 17 00:00:00 2001 From: Luca Stefani Date: Wed, 9 Sep 2020 11:04:45 +0200 Subject: [PATCH] incremental: Fix more clang-tidy warnings * performance-unnecessary-copy-initialization & performance-move-const-arg Test: m Change-Id: I50c6ee757392eac01630f264751a667cbd6e3c28 --- services/incremental/ServiceWrappers.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/incremental/ServiceWrappers.cpp b/services/incremental/ServiceWrappers.cpp index 99a35adb5074..af70d805bc11 100644 --- a/services/incremental/ServiceWrappers.cpp +++ b/services/incremental/ServiceWrappers.cpp @@ -239,7 +239,7 @@ class RealTimedQueueWrapper : public TimedQueueWrapper { auto it = mJobs.begin(); // Always acquire begin(). We can't use it after unlock as mTimedJobs can change. for (; it != mJobs.end() && it->when <= now; it = mJobs.begin()) { - auto job = std::move(it->what); + const auto& job = it->what; mJobs.erase(it); lock.unlock();