Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContainerTraits::size and BufferAdapterTraits::increaseBufferSize #80

Open
victorstewart opened this issue Jun 30, 2021 · 2 comments
Open

Comments

@victorstewart
Copy link
Contributor

victorstewart commented Jun 30, 2021

thoughts on renaming size to remainingCapacity? because it really requests remainingCapacity not size. just debugged an infinite loop where i'd implemented these as size when really the intention was remainingCapacity.

@fraillt
Copy link
Owner

fraillt commented Jul 1, 2021

Yes... you're absolutely right, I cannot explain how it slipped. I just don't know how should I fix this.
There are some nice improvements that deserve to be published in a new bistery version. This change is actually a breaking one, so I would want to avoid it... maybe adding [[deprected]] attribute to these functions, and creating new ones would be the way to go here.

@victorstewart
Copy link
Contributor Author

meant *rename lol. my mind was focused on remaining.

[[deprecated]] sounds like the least breaking way to fix it.

but say the version was changed to 6.0, it's not unheard of to have API breaking changes in new major versions. i suspect few people use these facilities since this wasn't noticed before, and they'd realize upon upgrading and compiling.

but either way is fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants