Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename error() function #62

Open
VelocityRa opened this issue Jul 15, 2020 · 1 comment
Open

Rename error() function #62

VelocityRa opened this issue Jul 15, 2020 · 1 comment

Comments

@VelocityRa
Copy link
Contributor

VelocityRa commented Jul 15, 2020

error is a really common name and if bitsery's user codebase defines it to a macro, bitsery won't compile.

Related to #48.

Feel free to close this if you think it's ridiculous :)

@fraillt
Copy link
Owner

fraillt commented Jul 15, 2020

Hello,
It's not ridiculous, but that would be a breaking change... and at the moment I don't want to introduce it without any additional value :)
On the other hand, I don't like current error handling mechanism, it's really limiting and doesn't allow custom error's from extensions. I would like it to replace with using standard types from <system_error>, but I don't like that it's a little heavy (brings in <string> and other issues), and that might restrict usage of the whole library in some environments.
So currently I'm waiting for p1023 and in the future, I'll revisit it, and then I will be able to change the name as well :)
So maybe this ticket can be left open, as a reminder, but I'm afraid that this is not something that will be resolved anytime soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants