Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to extract if filenames contains non ascii characters #52

Open
selganor74 opened this issue Dec 21, 2023 · 5 comments
Open

Fails to extract if filenames contains non ascii characters #52

selganor74 opened this issue Dec 21, 2023 · 5 comments

Comments

@selganor74
Copy link

I'm installing the amiga-gcc cross complier from https://github.com/bebbo/amiga-gcc .
The make all-sdk step fails when extracting the file ReqToolsDev.lha downloaded by the build process.

An lha -t ReqToolsDev.lha seems to give correct results:

ReqTools.info	- Tested   :  o
ReqTools/.Product-Info	- Tested   :  o
ReqTools/Catalogs/libcat/dansk.ct	- Tested   :  o
ReqTools/Catalogs/libcat/deutsch.ct	- Tested   :  o
ReqTools/Catalogs/libcat/espa?ol.ct	- Tested   :  o
ReqTools/Catalogs/libcat/fran?ais.ct	- Tested   :  o
ReqTools/Catalogs/libcat/italiano.ct	- Tested   :  o
ReqTools/Catalogs/libcat/magyar.ct	- Tested   :  o
ReqTools/Catalogs/libcat/nederlands.ct	- Tested   :  o
ReqTools/Catalogs/libcat/norsk.ct	- Tested   :  o
ReqTools/Catalogs/libcat/polski.ct	- Tested   :  o
ReqTools/Catalogs/libcat/portugu?s.ct	- Tested   :  o
ReqTools/Catalogs/libcat/reqtools.cd	- Tested   :  o
ReqTools/Catalogs/libcat/russian.ct	- Tested   :  o
ReqTools/Catalogs/libcat/srpski.ct	- Tested   :  o
ReqTools/Catalogs/libcat/suomi.ct	- Tested   :  o
ReqTools/Catalogs/libcat/svenska.ct	- Tested   :  o
ReqTools/Catalogs/libcat/?e?tina.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/dansk.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/deutsch.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/espa?ol.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/fran?ais.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/italiano.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/magyar.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/nederlands.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/norsk.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/polski.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/portugu?s.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/reqtoolsprefs.cd	- Tested   :  o
ReqTools/Catalogs/prefscat/russian.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/srpski.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/suomi.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/svenska.ct	- Tested   :  o
ReqTools/Catalogs/prefscat/?e?tina.ct	- Tested   :  o
ReqTools/Catalogs/README	- Tested   :  o
ReqTools/demo/demo.asm	- Tested   :  ooo
ReqTools/demo/demo.c	- Tested   :  oo
ReqTools/demo/demo.e	- Tested   :  oo
ReqTools/demo/makefile	- Tested   :  o
ReqTools/doc/reqtools.doc	- Tested   :  ooooooooo
ReqTools/doc/windowptr.readme	- Tested   :  o
ReqTools/fd/reqtools_lib.fd	- Tested   :  o
ReqTools/Glue/Dice/DLibSource.lha	- Tested   :  oo
ReqTools/Glue/Dice/README	- Tested   :  o
ReqTools/Glue/Dice/reqtools_protos.h	- Tested   :  o
ReqTools/Glue/Dice/reqtoolsl.lib	- Tested   :  o
ReqTools/Glue/Dice/reqtoolsrl.lib	- Tested   :  o
ReqTools/Glue/Dice/reqtoolss.lib	- Tested   :  o
ReqTools/Glue/Dice/reqtoolssr.lib	- Tested   :  o
ReqTools/Glue/GCC/gcc_glue.lha	- Tested   :  oooooooooooo
ReqTools/Glue/GCC/README	- Tested   :  o
ReqTools/Glue/HSPascal.1/hs_glue1.lha	- Tested   :  oooo
ReqTools/Glue/HSPascal.1/README	- Tested   :  o
ReqTools/Glue/HSPascal.2/hs_glue2.lha	- Tested   :  ooooooooooooooo
ReqTools/Glue/HSPascal.2/README	- Tested   :  o
ReqTools/Glue/M2Amiga/m2amiga_glue.lha	- Tested   :  ooooooooo
ReqTools/Glue/M2Amiga/README	- Tested   :  o
ReqTools/Glue/M2Sprint/m2sprint_glue.lha	- Tested   :  oooooooooooooo
ReqTools/Glue/M2Sprint/README	- Tested   :  o
ReqTools/Glue/Manx-C/README.src	- Tested   :  o
ReqTools/Glue/Manx-C/reqtools.lib	- Tested   :  o
ReqTools/Glue/Manx-C/reqtoolsnb.lib	- Tested   :  o
ReqTools/Glue/MaxonPascal/README	- Tested   :  o
ReqTools/Glue/MaxonPascal/RT-MaxonPAS.lha	- Tested   :  oooooooooooooooo
ReqTools/Glue/Oberon/oberon_glue.lha	- Tested   :  ooooo
ReqTools/Glue/Oberon/README	- Tested   :  o
ReqTools/Glue/PCQ/pcq_glue.lha	- Tested   :  oooooooooo
ReqTools/Glue/PCQ/README	- Tested   :  o
ReqTools/Glue/SAS-C/LibSource.lha	- Tested   :  ooooo
ReqTools/Glue/SAS-C/reqtools.lib	- Tested   :  o
ReqTools/Glue/SAS-C/reqtoolsnb.lib	- Tested   :  o
ReqTools/include/clib/reqtools_protos.h	- Tested   :  o
ReqTools/include/libraries/reqtools.h	- Tested   :  ooo
ReqTools/include/libraries/reqtools.i	- Tested   :  ooo
ReqTools/include/libraries/reqtools_lib.i	- Tested   :  o
ReqTools/include/pragmas/reqtools_pragmas.h	- Tested   :  o
ReqTools/include/proto/reqtools.h	- Tested   :  o
ReqTools/ReqTools.guide	- Tested   :  ooooooo
ReqTools/ReqTools.guide.info	- Tested   :  o
ReqTools/ReqToolsDev.readme	- Tested   :  o

but when extracting I obtain this:

$ lha -xw=build/reqtools/ download/ReqToolsDev.lha 
build/reqtools//ReqTools.info	- Melted   :  o
build/reqtools//ReqTools/.Product-Info	- Melted   :  o
build/reqtools//ReqTools/Catalogs/libcat/dansk.ct	- Melted   :  o
build/reqtools//ReqTools/Catalogs/libcat/deutsch.ct	- Melted   :  o
Failed to read file type of 'build/reqtools//ReqTools/Catalogs/libcat/espa�ol.ct'
@fragglet
Copy link
Owner

fragglet commented Dec 21, 2023

What version of Lhasa please? Run lha with no arguments and it should say.

And which OS too?

@polluks
Copy link
Contributor

polluks commented Dec 22, 2023

Here current lhasa works but looks weird (WSL's ext4)

$ ls -l ReqTools/Catalogs/libcat
total 64
-rw------- 1 stefan stefan 2073 Apr 24  1996  dansk.ct
-rw------- 1 stefan stefan 1975 Apr 24  1996  deutsch.ct
-rw------- 1 stefan stefan 1965 Apr 24  1996 'espa'$'\357\277\275''ol.ct'
-rw------- 1 stefan stefan 2347 Apr 24  1996 'fran'$'\357\277\275''ais.ct'
-rw------- 1 stefan stefan 1743 Apr 24  1996  italiano.ct
-rw------- 1 stefan stefan 2658 Apr 24  1996  magyar.ct
-rw------- 1 stefan stefan 1811 Feb 18  1996  nederlands.ct
-rw------- 1 stefan stefan 1921 Feb 20  1997  norsk.ct
-rw------- 1 stefan stefan 2366 Apr 24  1996  polski.ct
-rw------- 1 stefan stefan 2125 Apr 24  1996 'portugu'$'\357\277\275''s.ct'
-rw------- 1 stefan stefan 2074 Apr 24  1996  reqtools.cd
-rw------- 1 stefan stefan 2050 Jan 26  1997  russian.ct
-rw------- 1 stefan stefan 1990 Jan  5  1997  srpski.ct
-rw------- 1 stefan stefan 1942 Jan 15  1997  suomi.ct
-rw------- 1 stefan stefan 1994 Apr 24  1996  svenska.ct
-rw------- 1 stefan stefan 1678 Dec 16  1996 ''$'\357\277\275''e'$'\357\277\275''tina.ct'

@selganor74
Copy link
Author

selganor74 commented Dec 23, 2023 via email

@selganor74
Copy link
Author

selganor74 commented Dec 23, 2023 via email

@polluks
Copy link
Contributor

polluks commented Dec 27, 2023

@selganor74 Better attach the log next time.

By the way if an archive has Amiga permissions should we assume latin1 encoding..? Because an Amiga never supports Unicode.

FYI https://github.com/jca02266/lha#filename-encoding-in-the-archive and jca02266/lha#42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants