Skip to content

Commit cff595e

Browse files
committed
disable skip comments only when needed
1 parent dc253cd commit cff595e

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

backup.sh

+7-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,13 @@ do
2929
echo "==> Dumping database: $db"
3030
FILENAME=/backup/$DATE.$db.sql
3131
LATEST=/backup/latest.$db.sql
32-
if mysqldump --single-transaction --skip-comments $MYSQLDUMP_OPTS -h "$MYSQL_HOST" -P "$MYSQL_PORT" -u "$MYSQL_USER" -p"$MYSQL_PASS" $MYSQL_SSL_OPTS "$db" > "$FILENAME"
32+
BASIC_OPTS="--single-transaction"
33+
if [ -n "$REMOVE_DUPLICATES" ]
34+
then
35+
echo "WARNING: disabling comments in backup to remove deuplicate backups. Automatic database name detection won't work so set MYSQL_DATABASE on restore"
36+
BASIC_OPTS="$BASIC_OPTS" --skip-comments
37+
fi
38+
if mysqldump $BASIC_OPTS $MYSQLDUMP_OPTS -h "$MYSQL_HOST" -P "$MYSQL_PORT" -u "$MYSQL_USER" -p"$MYSQL_PASS" $MYSQL_SSL_OPTS "$db" > "$FILENAME"
3339
then
3440
EXT=
3541
if [ -z "${USE_PLAIN_SQL}" ]

docker-compose.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ services:
3030
environment:
3131
- MYSQL_HOST=my_mariadb
3232
- MYSQL_USER=root
33+
- MYSQL_DATABASE=${DATABASE_NAME}
3334
- MYSQL_PASS=${MARIADB_ROOT_PASSWORD}
3435
- MAX_BACKUPS=1
3536
- INIT_BACKUP=1

0 commit comments

Comments
 (0)