Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ngio] Refactor masked_loading_wrapper logic to do relabeling in the masking step #787

Open
jluethi opened this issue Jul 12, 2024 · 1 comment
Labels

Comments

@jluethi
Copy link
Collaborator

jluethi commented Jul 12, 2024

I have revisited how we handle masking & relabeling to fix #785 . For the moment, I do the relabeling in segment_ROI. In ngio, we'll want to do this in the wrapper class that handles the masking (currently masked_loading_wrapper). The main reason:

Current approach doesn't 100% guarantee consecutive labels. Within the cellpose task, there could be labels that are taken into account for relabeling but are masked away afterwards. That's very unlikely to be an issue, because we set the background to 0 in the input image. But the mock testing ignores the input

@jluethi
Copy link
Collaborator Author

jluethi commented Jul 12, 2024

Also, it will be nicer if that's functionality that comes with the IO package, instead of everyone that writes a function that creates labels having to take care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

1 participant