Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong "update search results" behavior when receiving a new message #200

Closed
AlexShukel opened this issue Jan 11, 2024 · 0 comments · Fixed by #201
Closed

Wrong "update search results" behavior when receiving a new message #200

AlexShukel opened this issue Jan 11, 2024 · 0 comments · Fixed by #201
Assignees
@AlexShukel
Labels
bug Something isn't working

Comments

@AlexShukel
Copy link
Collaborator

Describe the bug
When user searches a message in chat, the "receiveMessage" socket event interrupts search by scrolling to the first search result.

To Reproduce
Steps to reproduce the behavior:

  1. Enter some search string.
  2. Go to the next search result.
  3. Receive a message in this chat.
  4. See that chat is scrolling to the first search result.

Expected behavior
It is expected to update search results only if search sting matches new incoming message. Focused message should not be updated.
@AlexShukel AlexShukel added the bug Something isn't working label Jan 11, 2024
@AlexShukel AlexShukel self-assigned this Jan 11, 2024
@AlexShukel AlexShukel linked a pull request Jan 11, 2024 that will close this issue
Fixed 'update search results' behavior when receiving a new message #201
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexShukel AlexShukel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed 'update search results' behavior when receiving a new message fracht/rchat
1 participant
@AlexShukel