Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for foundry v12 #76

Open
Billiam9420 opened this issue Jun 18, 2024 · 8 comments
Open

Update for foundry v12 #76

Billiam9420 opened this issue Jun 18, 2024 · 8 comments

Comments

@Billiam9420
Copy link

Just realized this is not yet updated for v12. My existing articles work, and can be synced, however I can't import new ones! The WA button in the journal tab is unresponsive.

@aaclayton
Copy link
Contributor

Thanks for the report. We've been very busy with high priority items so I haven't had a chance to look at this module in a while. I'm definitely looking for contributors who are able to help maintain it. I'll try and look at it soon!

@Alikzander13
Copy link

Literally made an account just to follow this! hoping for an update in the near future. I relied on this feature heavily. Thanks for all the work you do! Wish I had the skills to help lol

@SnowDark38
Copy link

Sharing error related to this.

WA Button is visible and clickable. Clicking button elicits the following error in the console.

Error: An error occurred while rendering WorldAnvilBrowser 35. Cannot read properties of undefined (reading 'OBSERVER')
    at Hooks.onError (foundry.js:630:24)
    at 🎁call_wrapped [as call_wrapped] (libWrapper-wrapper.js:507:22)
    at 🎁Hooks.onError#lib-wrapper (listeners.js:138:11)
    at 🎁Hooks.onError#0 (libWrapper-wrapper.js:187:52)
    at foundry.js:5770:13Caused by: TypeError: Cannot read properties of undefined (reading 'OBSERVER')
    at WorldAnvilBrowser.getContentTree (journal.js:123:103)
    at async WorldAnvilBrowser.getData (journal.js:81:18)
    at async WorldAnvilBrowser._render (foundry.js:5813:18)

@Tillerz
Copy link
Contributor

Tillerz commented Aug 2, 2024

Can confirm, same error.

@Tillerz
Copy link
Contributor

Tillerz commented Aug 2, 2024

I just checked. If you go to modules/world-anvil/module/journal.js and comment out line 123, the list or articles shows up again.

article.visibleByPlayers = article.entry?.ownership.default >= CONST.DOCUMENT_PERMISSION_LEVELS.OBSERVER;

Comment it out by adding // in front.

ALAS, this deactivates the check if a page is visible to the players.

@Tillerz
Copy link
Contributor

Tillerz commented Aug 2, 2024

Found the error and fix it.

Pull Request here: 852d0fc

CONST.DOCUMENT_PERMISSION_LEVELS.* is now CONST.DOCUMENT_OWNERSHIP_LEVELS.*

@SnowDark38
Copy link

Thank you for looking into it! The only thing I know how to do is pull errors XD

@perlchild
Copy link

Thank you, my foundryv12 now updates from WorldAnvil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants