Artciles with a related timeline can't be imported

[cswendrowski]

In GitLab by @adrien.schiehle on Mar 14, 2021, 11:50

Hi, I'm new here, so first :

Thank you for this integration module !

It will allow me to create my article in advance and share what I want directly inside fvtt.

When I tried it, some of my articles couldn't be imported. Here was the stack :

framework.js:71 Uncaught (in promise) TypeError: Cannot read property 'id' of undefined
    at framework.js:71
    at Array.map (<anonymous>)
    at _getArticleContent (framework.js:71)
    at importArticle (framework.js:12)
    at async WorldAnvilBrowser._onClickControlButton (journal.js:146)

If I understand correctly, timeline relations inside an article are not correctly interpreted. section.items is undefined.

  // Article relations
  if ( article.relations ) {
    for ( let [id, section] of Object.entries(article.relations) ) {
      const title = section.title || id.titleCase();
      const items = section.items instanceof Array ? section.items: [section.items];  // Items can be one or many
      const relations = items.map(i => `<span data-article-id="${i.id}" data-template="${i.type}">${i.title}</span>`);
      aside += `<dt>${title}:</dt><dd>${relations.join(", ")}</dd>`
    }
  }

Something like this could do the job. What do you think ?

      let items = section.items;
      if( ! items ) {
         items = []; // There can be no items in an article relation. (Ex: timeline)
      } else if (! items instanceof Array ) {
         items = [section.items];  // Items can be one or many
      }