Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(installer): foundryup should only download when updates are available #9519

Open
2 tasks done
gosuto-inzasheru opened this issue Dec 9, 2024 · 1 comment
Open
2 tasks done
Labels
A-installer Area: installer A-releases Area: releases/packaging T-bug Type: bug

Comments

@gosuto-inzasheru
Copy link

Component

Foundryup

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (00efa0d 2024-12-09T00:29:01.805479000Z)

What command(s) is the bug in?

foundryup

Operating System

macOS (Apple Silicon)

Describe the bug

currently, running foundryup twice in a row will trigger a new download/installation of exactly the same version it installed previously. a lot of resources could be saved by comparing commits, and simply printing something along the lines of "Foundry is already up-to-date (00efa0d 2024-12-09T00:29:01.805479000Z)"

@gosuto-inzasheru gosuto-inzasheru added T-bug Type: bug T-needs-triage Type: this issue needs to be labelled labels Dec 9, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 9, 2024
@zerosnacks zerosnacks added A-installer Area: installer and removed T-needs-triage Type: this issue needs to be labelled labels Dec 9, 2024
@zerosnacks
Copy link
Member

cc @grandizzy possibly related to signed releases? we can then just check the local hash against the hash of the binary being pulled in

@zerosnacks zerosnacks added the A-releases Area: releases/packaging label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-installer Area: installer A-releases Area: releases/packaging T-bug Type: bug
Projects
Status: Todo
Development

No branches or pull requests

2 participants