bug(anvil): incorrectly adds +1 gas when estimating transactions with explicit empty data field (#10786)

* no input + empty input / test

* indent

* fmt

* clippy

* add no account auth verif

Author: gitToki

crates/anvil/src/eth/api.rs

@@ -2905,7 +2905,9 @@ impl EthApi {
         let to = request.to.as_ref().and_then(TxKind::to);
 
         // check certain fields to see if the request could be a simple transfer
-        let maybe_transfer = request.input.input().is_none() &&
+        let maybe_transfer = (request.input.input().is_none() ||
+            request.input.input().is_some_and(|data| data.is_empty())) &&
+            request.authorization_list.is_none() &&
             request.access_list.is_none() &&
             request.blob_versioned_hashes.is_none();
 

crates/anvil/tests/it/gas.rs

@@ -215,3 +215,46 @@ async fn test_can_use_fee_history() {
         assert_eq!(latest_fee_history_fee, next_base_fee as u64);
     }
 }
+
+#[tokio::test(flavor = "multi_thread")]
+async fn test_estimate_gas_empty_data() {
+    let (api, handle) = spawn(NodeConfig::test()).await;
+    let accounts = handle.dev_accounts().collect::<Vec<_>>();
+    let from = accounts[0];
+    let to = accounts[1];
+
+    let tx_without_data =
+        TransactionRequest::default().with_from(from).with_to(to).with_value(U256::from(1));
+
+    let gas_without_data = api
+        .estimate_gas(WithOtherFields::new(tx_without_data), None, Default::default())
+        .await
+        .unwrap();
+
+    let tx_with_empty_data = TransactionRequest::default()
+        .with_from(from)
+        .with_to(to)
+        .with_value(U256::from(1))
+        .with_input(vec![]);
+
+    let gas_with_empty_data = api
+        .estimate_gas(WithOtherFields::new(tx_with_empty_data), None, Default::default())
+        .await
+        .unwrap();
+
+    let tx_with_data = TransactionRequest::default()
+        .with_from(from)
+        .with_to(to)
+        .with_value(U256::from(1))
+        .with_input(vec![0x12, 0x34]);
+
+    let gas_with_data = api
+        .estimate_gas(WithOtherFields::new(tx_with_data), None, Default::default())
+        .await
+        .unwrap();
+
+    assert_eq!(gas_without_data, U256::from(GAS_TRANSFER));
+    assert_eq!(gas_with_empty_data, U256::from(GAS_TRANSFER));
+    assert!(gas_with_data > U256::from(GAS_TRANSFER));
+    assert_eq!(gas_without_data, gas_with_empty_data);
+}