Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that cheats that do not call the cheatcode address are still executed after a vm.expectRevert #948

Open
PaulRBerg opened this issue Jul 7, 2023 · 1 comment
Labels
T-enhancement Type: enhance existing docs T-to-fix Type: issue in docs
Milestone

Comments

@PaulRBerg
Copy link
Contributor

PaulRBerg commented Jul 7, 2023

Ref:

@IaroslavMazur
Copy link

@mds1's way of phrasing what should appear on the documentation page sounds the most suggestive, in my opinion:

"the book is trying to say "calls to other cheatcodes are not counted as 'the next call' when expecting a revert, and are ignored in that sense, but the cheatcode otherwise behaves normally", but it's not very clear"

@zerosnacks zerosnacks added T-to-fix Type: issue in docs T-enhancement Type: enhance existing docs labels Sep 17, 2024
@zerosnacks zerosnacks modified the milestone: v1.0.0 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-enhancement Type: enhance existing docs T-to-fix Type: issue in docs
Projects
No open projects
Status: Todo
Development

No branches or pull requests

3 participants