Remove aria-haspopup and tabindex from reveal button. Add aria-modal=true to modal container.

[MrDexterMorgan]

What is missing?

Consider to add aria-modal="true" to modal container since it is a modal.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-modal

From site docs on Reveal:
"Modal dialogs, or pop-up windows, are handy for prototyping and production. Foundation includes Reveal, our jQuery modal plugin, to make this easy for you."
...

What is wrong now ?

• aria-haspopup is being deprecated in ARIA 1.2 and gives the wrong context for AT users in many cases since it is regarded and spoken as a menu with specific keyboard navigation mechanism.

• tabindex=0 should not be used on an interactive element like the button is, what is the point for the redundacy?

...

Possible Solution

• Remove aria-haspopup and tabindex=0 from the button triggering the modal
• Add aria-modal=true to the modal container.

https://www.w3.org/TR/wai-aria-1.2/#aria-haspopup
...

Context

When having a button that is simly opening a modal it should not announce for AT users that it is a menu, how to activate the menu and how to navigate the menu, this gives the wrong context for the user.
...

Your Environment

• Foundation version(s) used: 6.7.5
• Browser(s) name and version(s): Google Chrome 114.0.5735.110
• Device, Operating System and version: PC, Windows 10 Enterprise

Checklist

• I have read and follow the CONTRIBUTING.md document.
• There are no other issues similar to this one.
• The issue title and template are correctly filled.