Debugging for release 1.1.1 - determined that loading PHP from JAR files is not supported by Resin 3.1... maybe in version 4?

Author: collegeman

lib/resin-3.1.jar

@@ -4,7 +4,7 @@
   <groupId>net.collegeman.phpinjava</groupId>
   <artifactId>php-in-java</artifactId>
   <packaging>jar</packaging>
-  <version>1.1.0</version>
+  <version>1.1.1</version>
   <name>php-in-java</name>
   <url>http://aaroncollegeman.com/projects/php-in-java</url>
 
@@ -75,17 +75,22 @@
 
 	<!-- quercus: -->
 	<dependency>
-	  <groupId>com.coucho</groupId>
+	  <groupId>com.caucho</groupId>
 	  <artifactId>quercus</artifactId>
 	  <version>3.1</version>
+    </dependency>
+	<dependency>
+	  <groupId>com.caucho</groupId>
+	  <artifactId>resin</artifactId>
+	  <version>3.1</version>
     </dependency>
     <dependency>
-	  <groupId>com.coucho</groupId>
+	  <groupId>com.caucho</groupId>
 	  <artifactId>resin-support</artifactId>
 	  <version>3.1</version>
     </dependency>
     <dependency>
-	  <groupId>com.coucho</groupId>
+	  <groupId>com.caucho</groupId>
 	  <artifactId>resin-util</artifactId>
 	  <version>3.1</version>
 	</dependency>

pom.xml

@@ -102,7 +102,6 @@ public PHP(String url, ClassLoader classLoader) {
 		if (classLoader == null)
 			throw new IllegalArgumentException("[classLoader] parameter must be defined");
 
-			
 		// classpath reference
 		if (url.indexOf("classpath:/") == 0) {
 			URL resource = classLoader.getResource(url.substring(11));
@@ -113,16 +112,8 @@ public PHP(String url, ClassLoader classLoader) {
 		// remote script
 		else if (url.indexOf("http://") == 0 || url.indexOf("https://") == 0) {
 			try {
-				StringBuilder script = new StringBuilder();
 				URLConnection conn = new URL(url).openConnection();
-				BufferedReader in = new BufferedReader(new InputStreamReader(conn.getInputStream()));
-				String line;
-				while ((line = in.readLine()) != null) {
-					script.append(line);
-					script.append("\n");
-				}
-				
-				snippet(script.toString());
+				initByInputStream(conn.getInputStream());
 			} catch (Exception e) {
 				throw new RuntimeException(e);
 			}
@@ -143,6 +134,22 @@ public PHP(File file) {
 		initByFile(file);
 	}
 
+	private void initByInputStream(InputStream stream) {
+		try {
+			StringBuilder sourceCode = new StringBuilder(1024);
+			BufferedReader in = new BufferedReader(new InputStreamReader(stream));
+			char[] buffer = new char[1024];
+			int read = 0;
+			while ((read = in.read(buffer)) != -1)
+				sourceCode.append(buffer, 0, read);
+			in.close();
+			
+			snippet(sourceCode.toString());
+		} catch (Exception e) {
+			throw new RuntimeException(e);
+		}
+	}
+	
 	private void initByFile(File ref) {
 		if (!ref.exists()) {
 			throw new RuntimeException(new FileNotFoundException("No PHP file or directory at ["+ref.getAbsolutePath()+"]"));

src/main/java/net/collegeman/phpinjava/PHP.java

@@ -0,0 +1,5 @@
+<?php
+
+function fx_in_lib() {
+	return true;
+}

src/test/resources/net/collegeman/phpinjava/php/lib/lib.php

@@ -0,0 +1,3 @@
+<?php
+
+require('lib/lib.php');