Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code link at the footer is working #1433

Closed
wants to merge 1 commit into from
Closed

code link at the footer is working #1433

wants to merge 1 commit into from

Conversation

samagragupta
Copy link
Member

@samagragupta samagragupta commented Jan 26, 2019 •
edited
Loading

Fixes #1432

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)
  • Added Surge preview link

Changes proposed in this pull request:

  • code link at the footer is working

@codecov
Copy link

codecov bot commented Jan 26, 2019 •
edited
Loading

Codecov Report

Merging #1433 into development will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1433      +/-   ##
===============================================
+ Coverage         61.3%   61.44%   +0.13%     
===============================================
  Files               51       51              
  Lines             1455     1455              
  Branches           180      180              
===============================================
+ Hits               892      894       +2     
+ Misses             454      449       -5     
- Partials           109      112       +3
Impacted Files Coverage Δ
src/app/speechtotext/speechtotext.component.ts 42.85% <0%> (-2.86%) ⬇️
src/app/services/intelligence.service.ts 75% <0%> (+4.16%) ⬆️
src/app/intelligence/intelligence.component.ts 76% <0%> (+12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6de390...0267b01. Read the comment docs.

subhahu123
subhahu123 suggested changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@subhahu123 subhahu123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samagragupta code link is working fine
please consider surge links for testing not the susper.com
because master is not updated with dev branch

No need of this

praveenojha33
praveenojha33 requested changes Feb 1, 2019
View reviewed changes
Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working fine please check on susper-dev.herokuapp.com.

simsausaurabh
simsausaurabh suggested changes Mar 27, 2019
View reviewed changes
Copy link
Member

@simsausaurabh simsausaurabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link fixing is fine. But what changes have you made in package-lock.json? and why?

@simsausaurabh
Copy link
Member

@samagragupta what is the status on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subhahu123 subhahu123 subhahu123 requested changes

@praveenojha33 praveenojha33 praveenojha33 requested changes

@simsausaurabh simsausaurabh simsausaurabh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code link not working
4 participants
@samagragupta @simsausaurabh @praveenojha33 @subhahu123