Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-build issues [Travis CI] #566

Open
1 of 2 tasks
areebbeigh opened this issue Jan 18, 2019 · 1 comment
Open
1 of 2 tasks

Fix pre-build issues [Travis CI] #566

areebbeigh opened this issue Jan 18, 2019 · 1 comment

Comments

@areebbeigh
Copy link
Member

areebbeigh commented Jan 18, 2019

I'm submitting a ...

  • bug report
  • feature request

Currently the Travis builds are failing before running the tests at the following points during linting:

  • /app/scrapers/yahoo.py:82:17
$ flake8 . --count --max-complexity=16 --show-source --statistics
./app/server.py:12:1: F841 local variable 'e' is assigned to but never used
except Exception as e:
^
./app/scrapers/yahoo.py:82:17: W605 invalid escape sequence '\d'
            cleanl = re.compile('&#[\d]+(;)')
                ^
1     F841 local variable 'e' is assigned to but never used
1     W605 invalid escape sequence '\d'
  • ./app/server.py:12:1
$ flake8 . --count --max-complexity=16 --show-source --statistics
./app/server.py:12:1: F841 local variable 'e' is assigned to but never used
except Exception as e:
^
1     F841 local variable 'e' is assigned to but never used

Before running tests:

I've already fixed these pre-build issues and Travis is successfully moving on to running the actual tests (which are failing due to other reasons).

areebbeigh added a commit to areebbeigh/query-server that referenced this issue Jan 18, 2019
areebbeigh added a commit to areebbeigh/query-server that referenced this issue Jan 18, 2019
areebbeigh added a commit to areebbeigh/query-server that referenced this issue Jan 18, 2019
@areebbeigh
Copy link
Member Author

I'll create a PR after confirmation from maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant