Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pin layout screens for PSLab v6 #2499

Open
marcnause opened this issue Jun 23, 2024 · 16 comments
Open

Add pin layout screens for PSLab v6 #2499

marcnause opened this issue Jun 23, 2024 · 16 comments
Assignees
Labels
Enhancement Improvement to an existing feature

Comments

@marcnause
Copy link
Contributor

Actual Behaviour

The app contains pin layout screens for PSlab v5.

Expected Behaviour

The app contains pin layout screens for PSlab v5 ans PSlab v6.

Steps to reproduce it

  1. Start app
  2. Press menu symbol (3 dots) in upper right
  3. Menu entries lead to pin layout screens for PSlab v5 only.

Would you like to work on the issue?

Maybe.

@marcnause marcnause added the Enhancement Improvement to an existing feature label Jun 23, 2024
@Surajkumar5050
Copy link

I would like to work on this issue. Please assign it to me, and I'll start by analyzing the current implementation for PSLab v5 and adding support for PSLab v6 pin layout screens.

@AsCress
Copy link
Collaborator

AsCress commented Dec 10, 2024

@Surajkumar5050 Sure! You can go ahead and work on this.

@samruddhi-Rahegaonkar
Copy link
Contributor

@Surajkumar5050 Are you working on this issue ?
@AsCress If he is not working I would like to solve this issue.

@Surajkumar5050
Copy link

Hi @samruddhi-Rahegaonkar , my exams are currently going on, so please feel free to work on this issue. You can ask @AsCress for this.

@samruddhi-Rahegaonkar
Copy link
Contributor

@AsCress Should I work on this issue?

@AsCress
Copy link
Collaborator

AsCress commented Dec 21, 2024

@samruddhi-Rahegaonkar Sure! Go ahead.

@marcnause
Copy link
Contributor Author

Just in case you have not seen it yet, images of the PSLab v6 board can be found at https://github.com/fossasia/pslab-hardware

@samruddhi-Rahegaonkar
Copy link
Contributor

Thanks! @marcnause Was looking for it only.

@samruddhi-Rahegaonkar
Copy link
Contributor

@AsCress Started working on this issue. any Guidelines for this?

@samruddhi-Rahegaonkar
Copy link
Contributor

@AsCress which editor has been used for color map for v5 image ?

@AsCress
Copy link
Collaborator

AsCress commented Jan 12, 2025

@samruddhi-Rahegaonkar How are you approaching this ?
I may not have an idea about the editor that was used for the color map.
@CloudyPadmal Do you have an idea about this ?

@samruddhi-Rahegaonkar
Copy link
Contributor

@AsCress All the process will same as v5 just need to create new xml and java files for v6 and creating new color map for v6 and pin informations dialog box after clicking on each pin.

@AsCress
Copy link
Collaborator

AsCress commented Jan 12, 2025

@samruddhi-Rahegaonkar That's great. And how would the user be switching between the pin layouts for the v6 and the v5 ?

@samruddhi-Rahegaonkar
Copy link
Contributor

@AsCress User can switch through pslab_connectivity_menu.xml we can add two more menus below v5 for v6.

@AsCress
Copy link
Collaborator

AsCress commented Jan 12, 2025

@AsCress User can switch through pslab_connectivity_menu.xml we can add two more menus below v5 for v6.

Yup. This would be nice to start with. Go ahead and implement whatever you find best.

@CloudyPadmal
Copy link
Collaborator

@samruddhi-Rahegaonkar How are you approaching this ?

I may not have an idea about the editor that was used for the color map.

@CloudyPadmal Do you have an idea about this ?

I used Inkscape for the design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants