From aa0ccc9969537e60d346ed1c59ddafaf2a9989a7 Mon Sep 17 00:00:00 2001 From: Dev Sebastian Date: Tue, 12 Jan 2021 22:30:58 +0530 Subject: [PATCH] changed return type of onDown in RecyclerItemClickListner to false as returning true was blocking the recyclerview scroll event - to fix #3051 --- .../org/fossasia/phimpme/base/RecyclerItemClickListner.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/fossasia/phimpme/base/RecyclerItemClickListner.java b/app/src/main/java/org/fossasia/phimpme/base/RecyclerItemClickListner.java index 9976b18ec..da35bc6ac 100644 --- a/app/src/main/java/org/fossasia/phimpme/base/RecyclerItemClickListner.java +++ b/app/src/main/java/org/fossasia/phimpme/base/RecyclerItemClickListner.java @@ -80,9 +80,8 @@ public void onLongPress(MotionEvent event) { @Override public boolean onDown(MotionEvent event) { - // Best practice to always return true here. - // http://developer.android.com/training/gestures/detector.html#detect - return true; + // returning true here will stop scroll event in recyclerview, return false instead + return false; } } }