improve cmake build

* use CMAKE_Fortran_MODULE_DIRECTORY to avoid introspecting directory structure
* don't build in-source, use test WORKING_DIRECTORY instead
* use modern add_test() syntax to avoid introspecting project directory structure
* use open(..., action=) to help indicate / safeguard intended file use
* don't have to accomodate CMake <= 2.4 circa 2006

Author: scivision

.github/workflows/main.yml

@@ -52,10 +52,10 @@ jobs:
       run: brew install gcc@${GCC_V} || brew upgrade gcc@${GCC_V} || true
 
     - name: Configure with CMake
-      run: cmake -Wdev -S . -B . # We should build out of source but loadtxt needs fixing
+      run: cmake -Wdev -DCMAKE_BUILD_TYPE=Release -B build
 
     - name: Build and compile
-      run: cmake --build . || cmake --build . --verbose --parallel 1
+      run: cmake --build build || cmake --build build --verbose --parallel 1
 
     - name: test
-      run: cmake --build . --target test
+      run: cmake --build build --target test

CMakeLists.txt

@@ -1,9 +1,8 @@
-cmake_minimum_required(VERSION 3.5.0 FATAL_ERROR)
-
-enable_language(Fortran)
-
-project(stdlib)
-
+cmake_minimum_required(VERSION 3.5.0)
+project(stdlib Fortran)
 enable_testing()
 
+# this avoids stdlib and projects using stdlib from having to introspect stdlib's directory structure
+set(CMAKE_Fortran_MODULE_DIRECTORY ${CMAKE_BINARY_DIR})
+
 add_subdirectory(src)

src/stdlib_experimental_io.f90

@@ -46,7 +46,7 @@ subroutine sloadtxt(filename, d)
 integer :: s
 integer :: nrow,ncol,i
 
-open(newunit=s, file=filename, status="old")
+open(newunit=s, file=filename, status="old", action="read")
 
 ! determine number of columns
 ncol = number_of_columns(s)
@@ -89,7 +89,7 @@ subroutine dloadtxt(filename, d)
 integer :: s
 integer :: nrow,ncol,i
 
-open(newunit=s, file=filename, status="old")
+open(newunit=s, file=filename, status="old", action="read")
 
 ! determine number of columns
 ncol = number_of_columns(s)
@@ -132,7 +132,7 @@ subroutine qloadtxt(filename, d)
 integer :: s
 integer :: nrow,ncol,i
 
-open(newunit=s, file=filename, status="old")
+open(newunit=s, file=filename, status="old", action="read")
 
 ! determine number of columns
 ncol = number_of_columns(s)
@@ -164,7 +164,7 @@ subroutine ssavetxt(filename, d)
 ! call savetxt("log.txt", data)
 
 integer :: s, i
-open(newunit=s, file=filename, status="replace")
+open(newunit=s, file=filename, status="replace", action="write")
 do i = 1, size(d, 1)
     write(s, *) d(i, :)
 end do
@@ -187,7 +187,7 @@ subroutine dsavetxt(filename, d)
 ! call savetxt("log.txt", data)
 
 integer :: s, i
-open(newunit=s, file=filename, status="replace")
+open(newunit=s, file=filename, status="replace", action="write")
 do i = 1, size(d, 1)
     write(s, *) d(i, :)
 end do
@@ -210,7 +210,7 @@ subroutine qsavetxt(filename, d)
 ! call savetxt("log.txt", data)
 
 integer :: s, i
-open(newunit=s, file=filename, status="replace")
+open(newunit=s, file=filename, status="replace", action="write")
 do i = 1, size(d, 1)
     write(s, *) d(i, :)
 end do
@@ -243,17 +243,17 @@ integer function number_of_rows_numeric(s)
  ! determine number or rows
  integer,intent(in)::s
  integer :: ios
- 
+
  real::r
- 
+
  rewind(s)
  number_of_rows_numeric = 0
  do
     read(s, *, iostat=ios) r
     if (ios /= 0) exit
     number_of_rows_numeric = number_of_rows_numeric + 1
  end do
- 
+
  rewind(s)
 
 end function

src/tests/ascii/CMakeLists.txt

@@ -1,9 +1,6 @@
-include_directories(${PROJECT_BINARY_DIR}/src)
-
 project(ascii)
 
 add_executable(test_ascii test_ascii.f90)
 target_link_libraries(test_ascii fortran_stdlib)
 
-add_test(test_ascii ${PROJECT_BINARY_DIR}/test_ascii)
-
+add_test(NAME ASCII COMMAND $<TARGET_FILE:test_ascii>)

src/tests/loadtxt/CMakeLists.txt

@@ -1,5 +1,3 @@
-include_directories(${PROJECT_BINARY_DIR}/src)
-
 project(loadtxt)
 
 add_executable(test_loadtxt test_loadtxt.f90)
@@ -8,8 +6,7 @@ target_link_libraries(test_loadtxt fortran_stdlib)
 add_executable(test_savetxt test_savetxt.f90)
 target_link_libraries(test_savetxt fortran_stdlib)
 
-add_test(test_loadtxt ${PROJECT_BINARY_DIR}/test_loadtxt)
-add_test(test_savetxt ${PROJECT_BINARY_DIR}/test_savetxt)
-
-file(COPY array1.dat  array2.dat  array3.dat  array4.dat
-     DESTINATION ${CMAKE_CURRENT_BINARY_DIR})
+add_test(NAME load_text COMMAND $<TARGET_FILE:test_loadtxt>
+  WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR})
+add_test(NAME save_text COMMAND $<TARGET_FILE:test_savetxt>
+  WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR})