Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppLayout – Improvements #125

Open
2 of 14 tasks
mkrause opened this issue Feb 5, 2025 · 0 comments
Open
2 of 14 tasks

AppLayout – Improvements #125

mkrause opened this issue Feb 5, 2025 · 0 comments

Comments

@mkrause
Copy link
Collaborator

mkrause commented Feb 5, 2025

This is a follow up to #122.

There are a few improvements we'd like to make to the AppLayout components:

  • Make AppLayout more ergonomic to use:
    • Less boilerplate to set up all the <main>, <header>, etc. elements. (DONE: introduced AppLayout.Xxx shorthands.)
    • To override NavItem with a custom Link element, currently the consumer must reimplement a bunch of styling, the icon, etc. Maybe we can add a prop to customize the Link component? (DONE: added a Link prop.)
    • Currently the consumer must manually set bkl-theme--dark on the various components. Should we do this out of the box?
  • Enforce accessibility: e.g. need to enforce that unique aria-label are set if there are multiple Nav elements (each is a landmark).
  • Collapsible sidebar. Should include tooltips for all nav menu items.
  • Additional buttons in the header next to the user profile (e.g. notification bell, help menu).
  • Fix up Storybook stories: more stories for subcomponents, fix the display in light mode.
  • Breadcrumbs: should we have some margin by default underneath the breadcrumbs to space it out from the content? Maybe a trimmed prop in case the user wants to override it.
  • Breadcrumbs should use a composition pattern (child elements) for the items rather than a JSON object.
  • Should we have a Footer component?

Some minor issues:

  • Fix the selected account being displayed as "account_Account 1" etc.
  • Fix the styling of the "Add account" action in the Accounts dropdown.
  • Add a "Manage solutions" action to Solutions dropdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant