Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(German)(de-de) play next/previous song not working #140

Open
Loopinglu opened this issue May 23, 2020 · 12 comments
Open

(German)(de-de) play next/previous song not working #140

Loopinglu opened this issue May 23, 2020 · 12 comments

Comments

@Loopinglu
Copy link

When I say "Spiele das nächste Lied" it only tells me which song is currently playing instead of switching to the next one.
When I say "Spiele das vorherige Lied" it start to play some news radio station. He does that actually quite often, even when I just want him to play something from phil collins "spiele etwas von phil collins". It's different radio stations though haha

@forslund
Copy link
Owner

Hi, it's actually not the spotify skill that is responsible for the next/previous commands. it uses the mycroft-playback-control to handle the common previous / next track commands. Check the translation of that skill (looks like next is translated as "nächster" only maybe it should be changed to (nächste|nächtster|nächtstes) or something.

Is there a special radio station that is picked up by "spiele etwas von phil collins"? or is it the default station?

@Loopinglu
Copy link
Author

Loopinglu commented May 24, 2020

alright, so how come it does not recognise the command as aiming for raspotify but for this radio-thing?

Can I just create alternative commands by writing the words in brackets and seperate them by a | ?

And no, it feels like it's always another radio station...

@forslund
Copy link
Owner

So this a bit hard to say for sure. The command generates a confidence based on the utterance, if it can detect that you asks for an album or artist or track it will report a higher confidence than if it's a generic query "play phil collins" So here it may be an issue with the translation of the regex for determining that it's an artist query. Alternatively the News skill is over matching and reporting that it is very sure that Phil Collins is a radio station :)

Yes you can create alternative keywords by using the parenthesis + pipe expansion (word1|word2|word3).

@forslund
Copy link
Owner

Checking the german regex it looks ok. Tomorrow I'll switch my Mycroft over to german to see if I can get some more insight into the issue.

@forslund
Copy link
Owner

I've tried some today and it seems like the news skill is over-matching. I get my default news if I ask "play discover weekly" but if I say "play discover weekly on spotify" Spotify gets precedence.

@Loopinglu
Copy link
Author

Loopinglu commented May 25, 2020

Yeah exactly if one adds "on Spotify" it works. So is there any way to stop this overmatching?

@forslund
Copy link
Owner

I'll be checking the news skill and see if I should boost the confidence here slightly or if we should decrease the confidence for the npr-news

@Loopinglu
Copy link
Author

Any progress on this issue? How does one boost or decrease the confidence?

@forslund
Copy link
Owner

Sorry for the slow response, I think I can do an update to at least make this better. If a query has a low matching value it's reported as a GENERIC match. See L444

would be good if you can try to change that line to read

                        level = CPSMatchLevel.TITLE

and see if the issue goes away.

@Loopinglu
Copy link
Author

I tried it but the radio skills still let's activated :(

@penrods
Copy link
Collaborator

penrods commented Jun 12, 2020

Seems like this issue is in the generic "skill-playback-control". It believe you are saying the equivalent of "play the next song" in German, correct? The words "next" and "song" are matches in English for the generic control from .voc file. However "nächste" and "Leid" are not in the German translations of these files:

Next.voc -- has "next" in English but German vocabulary is missing "nächste":
https://github.com/MycroftAI/skill-playback-control/blob/20.02/locale/en-us/Track.voc
https://github.com/MycroftAI/skill-playback-control/blob/20.02/locale/de-de/Track.voc

and Track.voc -- has "song" in English but German vocabulary is missing "Leid":
https://github.com/MycroftAI/skill-playback-control/blob/20.02/locale/en-us/Track.voc
https://github.com/MycroftAI/skill-playback-control/blob/20.02/locale/de-de/Track.voc

@Loopinglu
Copy link
Author

Loopinglu commented Jun 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants