From 9ac6e68d0c0b2a1b9224b0bbba84578f4dbb1769 Mon Sep 17 00:00:00 2001
From: Abdelrahman Awad <logaretm1@gmail.com>
Date: Sun, 12 Jan 2025 00:12:32 +0200
Subject: [PATCH] feat: rename popup props to listbox props

---
 packages/core/src/useComboBox/useComboBox.ts  | 2 +-
 packages/core/src/useSelect/useSelect.spec.ts | 6 +++---
 packages/core/src/useSelect/useSelect.ts      | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/packages/core/src/useComboBox/useComboBox.ts b/packages/core/src/useComboBox/useComboBox.ts
index fabbcb50..3df1db73 100644
--- a/packages/core/src/useComboBox/useComboBox.ts
+++ b/packages/core/src/useComboBox/useComboBox.ts
@@ -275,7 +275,7 @@ export function useComboBox<TOption, TValue = TOption>(_props: Reactivify<ComboB
        */
       errorMessageProps,
       /**
-       * Props for the listbox element.
+       * Props for the listbox/popup element.
        */
       listBoxProps,
       /**
diff --git a/packages/core/src/useSelect/useSelect.spec.ts b/packages/core/src/useSelect/useSelect.spec.ts
index 9f9a9b16..09d212b9 100644
--- a/packages/core/src/useSelect/useSelect.spec.ts
+++ b/packages/core/src/useSelect/useSelect.spec.ts
@@ -51,7 +51,7 @@ function createSelect() {
       const {
         labelProps,
         triggerProps,
-        popupProps,
+        listBoxProps,
         errorMessageProps,
         descriptionProps,
         displayError,
@@ -73,7 +73,7 @@ function createSelect() {
         fieldValue,
         labelProps,
         triggerProps,
-        popupProps,
+        listBoxProps,
         errorMessageProps,
         descriptionProps,
         displayError,
@@ -92,7 +92,7 @@ function createSelect() {
             {{ fieldValue || 'Select here' }}
           </div>
 
-          <div v-bind="popupProps" popover>
+          <div v-bind="listBoxProps" popover>
             <slot>
               <template v-if="groups">
                 <OptionGroup v-for="group in groups" :key="group.label" :label="group.label">
diff --git a/packages/core/src/useSelect/useSelect.ts b/packages/core/src/useSelect/useSelect.ts
index 5ae283d1..8a29b278 100644
--- a/packages/core/src/useSelect/useSelect.ts
+++ b/packages/core/src/useSelect/useSelect.ts
@@ -279,9 +279,9 @@ export function useSelect<TOption, TValue = TOption>(_props: Reactivify<SelectPr
        */
       labelProps,
       /**
-       * Props for the popup element.
+       * Props for the listbox/popup element.
        */
-      popupProps: listBoxProps,
+      listBoxProps,
       /**
        * Props for the error message element.
        */