Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to check if @newjudgements have been used? #108

Open
nickhaf opened this issue Nov 4, 2023 · 1 comment
Open

Do we need to check if @newjudgements have been used? #108

nickhaf opened this issue Nov 4, 2023 · 1 comment
Assignees

Comments

@nickhaf
Copy link
Collaborator

nickhaf commented Nov 4, 2023

@aaronpeikert :

If I've seen correctly, we currently don't check if the @newjudgements implemented by us or the user are actually used.
Suppose I'm a coder and want to code the Language of each record, so I build a newjudgement for it:

@newjudgement("Lang" ...)

How can I get reminded each time I build a record to actually make this newjudgement?

I already played around with it a bit, one possibility would be to add a new argument to @newjudgement called required. If it is set to true, this @newjudgement has to be made on it's respective level. So we would need some kind of list with all judgements available for the different levels, and compare that list with the judgements made for Record(), Study() ... each time Record(), Study() ... is called. However, this got a bit bulky, so I wasn't sure if we a) actually want that feature, and b) how to best implement it.

@aaronpeikert
Copy link
Contributor

We definetely should! Now that I think about not even that complicated. We could use the preferences mechanism that is also used here:

@set_preferences!("auto_request_meta" => x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants