You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Narratives makes application crash when following documentation for Timemap + Datasheet.
Environment
In local development.
For data source, I'm running the datasheet locally with the example sheet in https://github.com/forensic-architecture/datasheet-server/blob/main/data/timemap_data.xlsx, which contains some example narratives.
In timemap, I'm rendering everything correctly. However, when going into narratives, the application crashes (black screen).
I've cloned the repo from the latest commit (32feff8) .
Current Behavior
When opening the menu by clicking on Narratives on the left tool bar and clicking on one of the examples, the application goes black and crashes.
Narratives makes application crash when following documentation for Timemap + Datasheet.
Environment
In local development.
For data source, I'm running the datasheet locally with the example sheet in
https://github.com/forensic-architecture/datasheet-server/blob/main/data/timemap_data.xlsx
, which contains some example narratives.In timemap, I'm rendering everything correctly. However, when going into narratives, the application crashes (black screen).
I've cloned the repo from the latest commit (32feff8) .
Current Behavior
When opening the menu by clicking on
Narratives
on the left tool bar and clicking on one of the examples, the application goes black and crashes.The following line is missing a check on load:
https://github.com/forensic-architecture/timemap/blob/main/src/components/CardStack.jsx#L29
const cardScroll = this.refs[this.props.narrative.current].current
This line finds
this.props.narrative
undefined, and so crashes.Expected Behavior
If undefined, handle gracefully.
The text was updated successfully, but these errors were encountered: