-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug, new ERRORs after 0.7.24 #2858
Comments
At the same time, it would be great to have the meaning of checks included in the report.md file. Made a comment on this here |
@vv-monsalve, I initially thought this ERROR would be in a PR to the Then I cloned https://github.com/vv-monsalve/GUPTER.git and tried to run the latest fontbakery (form git master) on the bold ttf from the Please let me know where I can find files that cause the ERROR. |
I ran the FB cheks on my local files that are up to date with my master branch of the upstream repo, I didn't change anything on them, so this is more strange to me now. I did this on this project actually because I wanted to test the upgrade of Fontbakery on an already proved working job. Before it, I tried to upgrade it in another project, but even though I received the "successfully installed 0.7.24" after three attempts, it remained in 0.7.22. It only got updated after I delete the venv and reinstall the gftools. Link to a copy of my local Gupter folder. On FONTS/TTF, you can find the resulted folders of the two last QA processes performed and a .txt file with the terminal output, so you can check if I did something wrong. |
@vv-monsalve, thanks for the feedback! |
@vv-monsalve, I have the impression that you have
then install fontbakery and try to run the check agains Gupter again and let me know if that solves the issue. |
@felipesanches The venv was built on python 3.6. |
oh, ok! So maybe you had an older Anyway... I'll keep trying to replicate the bug. Thanks for sending more files. I'll look them up now. |
Sure, no problem. I gave it a quick look and didn't see python 2.7, strange. I hope the new files are of any help! |
It seems like this was caused by conflicts between python versions indeed. After checking this locally with @m4rc1e I created a new venv with selected python 3.7 and everything worked ok with FB. |
Observed behavior
After running last 0.7.24 FontBakery version I got some new errors
The report is included on Resources
Expected behavior
The Error to be solved
Resources and exact process needed to replicate
Fontbakery version: 0.7.24
[7] Gupter-Bold.ttf
💔 ERROR: Glyphs are similiar to Google Fonts version?
com.google.fonts/check/production_glyphs_similarity
💔 ERROR Failed with TypeError: new() missing 6 required positional arguments: 'xx', 'xy', 'yx', 'yy', 'dx', and 'dy'
The text was updated successfully, but these errors were encountered: