Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fonts passed as buffers with missing postscript name not displayed when using multiple fonts #691

Closed
homerjam opened this issue Jun 21, 2017 · 2 comments
Closed

Fonts passed as buffers with missing postscript name not displayed when using multiple fonts #691

homerjam opened this issue Jun 21, 2017 · 2 comments

Comments

@homerjam
Copy link

Hi Devon,

Are these lines providing any significant performance benefit? When I remove them my issue is solved, alternatively I can re-implement the fix from #603 with id fallback for invalid fonts?

Thanks
@homerjam homerjam changed the title Fonts passed as buffers with missing name not displayed when using multiple fonts Fonts passed as buffers with missing postscript name not displayed when using multiple fonts Jun 21, 2017
@homerjam homerjam mentioned this issue Jun 21, 2017
Closed
@homerjam
Copy link
Author

Hi Devon, any thoughts on this?

As far as I can work out he previous fix you did doesn't take into account fonts that exist in the document already that don't have names. So can we remove these lines? Or should we go back to the fallback approach?

liborm85 added a commit that referenced this issue Dec 27, 2024
@liborm85
Fix font cache collision for fonts with missing postscript name or ba…
42172c5 
…d TTF metadata #1384 #691
@liborm85
Copy link
Collaborator

You did not attach any font to test, but probably solved by #1384 (comment).

liborm85 added a commit to foliojs-fork/pdfkit that referenced this issue Dec 31, 2024
@liborm85
Fix font cache collision for fonts with missing postscript name or ba…
8a0cfd5 
…d TTF metadata foliojs#1384 foliojs#691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use font name (or id as fallback) to identify font homerjam/pdfkit
2 participants
@homerjam @liborm85