From 4b6c68c96c49f4dd87d65dc6047d81171e6858c6 Mon Sep 17 00:00:00 2001
From: Priyanka Terala <priyanka_terala@epam.com>
Date: Mon, 30 Dec 2024 14:07:54 +0530
Subject: [PATCH] UIU-3141 - refactor away from default props for functional
 components.

---
 CHANGELOG.md                                   |  1 +
 .../AffiliationsManager/AffiliationsManager.js | 12 +++---------
 .../AffiliationsSelect/AffiliationsSelect.js   |  6 +-----
 .../AssignedUsers/AssignedUsersContainer.js    | 11 ++++++-----
 .../AssignedUsers/AssignedUsersList.js         |  7 +------
 .../BulkRenewalDialog/BulkRenewedLoansList.js  |  7 +------
 .../ChangeUserTypeModal/ChangeUserTypeModal.js |  6 +-----
 .../CheckboxColumn/CheckboxColumn.js           |  9 ++-------
 .../Loans/components/ActionsBar/ActionsBar.js  |  7 +------
 .../PermissionsAccordion.js                    | 18 +++++-------------
 .../CheckboxColumn/CheckboxColumn.js           |  9 ++-------
 .../ShowLongContentInPopover.js                |  9 ++-------
 12 files changed, 26 insertions(+), 76 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 36a3566d0..67e77a292 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,7 @@
 * Fix issue with `Proxy borrower` field value. Refs UIU-3290.
 * Remove duplicates from the keyboard shortcut modal. Refs UIU-3026.
 * Add sub permission `manual-block-templates.collection.get` to permission `Users: Can create, edit and remove patron blocks`. Refs UIU-3305.
+* React v19: refactor away from default props for functional components. Refs. UIU-3141.
 
 ## [11.0.9](https://github.com/folio-org/ui-users/tree/v11.0.9) (2024-12-13)
 [Full Changelog](https://github.com/folio-org/ui-users/compare/v11.0.8...v11.0.9)
diff --git a/src/components/AffiliationsManager/AffiliationsManager.js b/src/components/AffiliationsManager/AffiliationsManager.js
index 257609f4a..b0bb0368d 100644
--- a/src/components/AffiliationsManager/AffiliationsManager.js
+++ b/src/components/AffiliationsManager/AffiliationsManager.js
@@ -5,11 +5,11 @@ import { AffiliationsManagerModal } from './AffiliationsManagerModal';
 import AffiliationsManagerTrigger from './AffiliationsManagerTrigger';
 
 const AffiliationsManager = ({
-  disabled,
+  disabled = false,
   onUpdateAffiliations,
-  renderTrigger,
+  renderTrigger = AffiliationsManagerTrigger,
   userId,
-  withTrigger,
+  withTrigger = true,
 }) => {
   const [isModalOpen, toggleModal] = useToggle(!withTrigger);
 
@@ -36,10 +36,4 @@ AffiliationsManager.propTypes = {
   withTrigger: PropTypes.bool,
 };
 
-AffiliationsManager.defaultProps = {
-  disabled: false,
-  renderTrigger: AffiliationsManagerTrigger,
-  withTrigger: true,
-};
-
 export default AffiliationsManager;
diff --git a/src/components/AffiliationsSelect/AffiliationsSelect.js b/src/components/AffiliationsSelect/AffiliationsSelect.js
index 18faab0b1..6dcde943f 100644
--- a/src/components/AffiliationsSelect/AffiliationsSelect.js
+++ b/src/components/AffiliationsSelect/AffiliationsSelect.js
@@ -13,7 +13,7 @@ import { Selection } from '@folio/stripes/components';
 import { affiliationsShape } from '../../shapes';
 
 const AffiliationsSelect = ({
-  id,
+  id = 'user-assigned',
   affiliations,
   value,
   onChange,
@@ -53,10 +53,6 @@ const AffiliationsSelect = ({
   );
 };
 
-AffiliationsSelect.defaultProps = {
-  id: 'user-assigned',
-};
-
 AffiliationsSelect.propTypes = {
   affiliations: affiliationsShape,
   onChange: PropTypes.func.isRequired,
diff --git a/src/components/AssignedUsers/AssignedUsersContainer.js b/src/components/AssignedUsers/AssignedUsersContainer.js
index 996a33385..54da168b6 100644
--- a/src/components/AssignedUsers/AssignedUsersContainer.js
+++ b/src/components/AssignedUsers/AssignedUsersContainer.js
@@ -24,7 +24,12 @@ import AssignUsers from './AssignUsers';
 import AssignedUsersList from './AssignedUsersList';
 import { getUpdatedUsersList } from './utils';
 
-const AssignedUsersContainer = ({ permissionSetId, expanded, onToggle, tenantId }) => {
+const AssignedUsersContainer = ({
+  permissionSetId,
+  expanded = true,
+  onToggle,
+  tenantId
+}) => {
   const callout = useCallout();
   const intl = useIntl();
 
@@ -123,8 +128,4 @@ AssignedUsersContainer.propTypes = {
   tenantId: PropTypes.string,
 };
 
-AssignedUsersContainer.defaultProps = {
-  expanded: true,
-};
-
 export default AssignedUsersContainer;
diff --git a/src/components/AssignedUsers/AssignedUsersList.js b/src/components/AssignedUsers/AssignedUsersList.js
index b4c7234a3..7e3b14d8f 100644
--- a/src/components/AssignedUsers/AssignedUsersList.js
+++ b/src/components/AssignedUsers/AssignedUsersList.js
@@ -12,7 +12,7 @@ import {
   VISIBLE_COLUMNS,
 } from './constants';
 
-const AssignedUsersList = ({ users, isFetching }) => (
+const AssignedUsersList = ({ users = [], isFetching = false }) => (
   <Row
     start="xs"
     data-test-assigned-users
@@ -34,9 +34,4 @@ AssignedUsersList.propTypes = {
   isFetching: PropTypes.bool,
 };
 
-AssignedUsersList.defaultProps = {
-  users: [],
-  isFetching: false,
-};
-
 export default AssignedUsersList;
diff --git a/src/components/BulkRenewalDialog/BulkRenewedLoansList.js b/src/components/BulkRenewalDialog/BulkRenewedLoansList.js
index 4bd0125f5..0a4ad7981 100644
--- a/src/components/BulkRenewalDialog/BulkRenewedLoansList.js
+++ b/src/components/BulkRenewalDialog/BulkRenewedLoansList.js
@@ -24,15 +24,11 @@ const propTypes = {
   errorMessages: PropTypes.object.isRequired,
 };
 
-const defaultProps = {
-  height: 300,
-};
-
 const BulkRenewedLoansList = (props) => {
   const {
     failedRenewals,
     successRenewals,
-    height,
+    height = 300,
     errorMessages,
     requestCounts,
     loanPolicies,
@@ -126,7 +122,6 @@ const BulkRenewedLoansList = (props) => {
   );
 };
 
-BulkRenewedLoansList.defaultProps = defaultProps;
 BulkRenewedLoansList.propTypes = propTypes;
 
 export default BulkRenewedLoansList;
diff --git a/src/components/EditSections/EditUserInfo/components/ChangeUserTypeModal/ChangeUserTypeModal.js b/src/components/EditSections/EditUserInfo/components/ChangeUserTypeModal/ChangeUserTypeModal.js
index dece42bc5..863d4e517 100644
--- a/src/components/EditSections/EditUserInfo/components/ChangeUserTypeModal/ChangeUserTypeModal.js
+++ b/src/components/EditSections/EditUserInfo/components/ChangeUserTypeModal/ChangeUserTypeModal.js
@@ -9,7 +9,7 @@ import {
 
 import { USER_TYPES } from '../../../../../constants';
 
-const ChangeUserTypeModal = ({ onChange, initialUserType, open }) => {
+const ChangeUserTypeModal = ({ onChange, initialUserType, open = false }) => {
   const userTypeModalFooter = (
     <ModalFooter>
       <Button
@@ -47,8 +47,4 @@ ChangeUserTypeModal.propTypes = {
   open: PropTypes.bool,
 };
 
-ChangeUserTypeModal.defaultProps = {
-  open: false,
-};
-
 export default ChangeUserTypeModal;
diff --git a/src/components/EditSections/EditUserRoles/components/CheckboxColumn/CheckboxColumn.js b/src/components/EditSections/EditUserRoles/components/CheckboxColumn/CheckboxColumn.js
index 7863ee63b..442006136 100644
--- a/src/components/EditSections/EditUserRoles/components/CheckboxColumn/CheckboxColumn.js
+++ b/src/components/EditSections/EditUserRoles/components/CheckboxColumn/CheckboxColumn.js
@@ -9,9 +9,9 @@ import css from './CheckboxColumn.css';
 const CheckboxColumn = memo(props => {
   const {
     value,
-    checked,
+    checked = false,
     roleName,
-    onChange,
+    onChange = noop,
   } = props;
 
   return (
@@ -39,9 +39,4 @@ CheckboxColumn.propTypes = {
   onChange: PropTypes.func,
 };
 
-CheckboxColumn.defaultProps = {
-  checked: false,
-  onChange: noop,
-};
-
 export default CheckboxColumn;
diff --git a/src/components/Loans/components/ActionsBar/ActionsBar.js b/src/components/Loans/components/ActionsBar/ActionsBar.js
index c522f4d02..ca17e1311 100644
--- a/src/components/Loans/components/ActionsBar/ActionsBar.js
+++ b/src/components/Loans/components/ActionsBar/ActionsBar.js
@@ -12,11 +12,7 @@ const propTypes = {
   contentEnd: PropTypes.oneOfType([PropTypes.element, PropTypes.func]),
 };
 
-const defaultProps = {
-  show: true,
-};
-
-const ActionsBar = ({ show, contentStart, contentEnd }) => {
+const ActionsBar = ({ show = true, contentStart, contentEnd }) => {
   if (!show) {
     return null;
   }
@@ -30,6 +26,5 @@ const ActionsBar = ({ show, contentStart, contentEnd }) => {
 };
 
 ActionsBar.propTypes = propTypes;
-ActionsBar.defaultProps = defaultProps;
 
 export default ActionsBar;
diff --git a/src/components/PermissionsAccordion/PermissionsAccordion.js b/src/components/PermissionsAccordion/PermissionsAccordion.js
index 8c673cdc4..fa76a26b9 100644
--- a/src/components/PermissionsAccordion/PermissionsAccordion.js
+++ b/src/components/PermissionsAccordion/PermissionsAccordion.js
@@ -33,9 +33,9 @@ const PermissionsAccordion = (props) => {
   const {
     accordionId,
     affiliations,
-    disabled,
+    disabled = false,
     expanded,
-    onChangeAffiliation,
+    onChangeAffiliation = noop,
     onToggle,
     permToModify,
     permToDelete,
@@ -43,9 +43,9 @@ const PermissionsAccordion = (props) => {
     filtersConfig,
     visibleColumns,
     headlineContent,
-    excludePermissionSets,
-    initialValues: { personal },
-    isLoading,
+    excludePermissionSets = false,
+    initialValues: { personal } = {},
+    isLoading = false,
     form: { change },
     setButtonRef,
     tenantId,
@@ -310,12 +310,4 @@ PermissionsAccordion.propTypes = {
   setButtonRef: PropTypes.func
 };
 
-PermissionsAccordion.defaultProps = {
-  disabled: false,
-  excludePermissionSets: false,
-  initialValues: {},
-  isLoading: false,
-  onChangeAffiliation: noop,
-};
-
 export default stripesConnect(injectIntl(PermissionsAccordion));
diff --git a/src/components/PermissionsAccordion/components/CheckboxColumn/CheckboxColumn.js b/src/components/PermissionsAccordion/components/CheckboxColumn/CheckboxColumn.js
index bfb1dab4c..b1c0b7b0f 100644
--- a/src/components/PermissionsAccordion/components/CheckboxColumn/CheckboxColumn.js
+++ b/src/components/PermissionsAccordion/components/CheckboxColumn/CheckboxColumn.js
@@ -9,9 +9,9 @@ import css from './CheckboxColumn.css';
 const CheckboxColumn = memo(props => {
   const {
     value,
-    checked,
+    checked = false,
     permissionName,
-    onChange,
+    onChange = noop,
   } = props;
 
   return (
@@ -39,9 +39,4 @@ CheckboxColumn.propTypes = {
   onChange: PropTypes.func,
 };
 
-CheckboxColumn.defaultProps = {
-  checked: false,
-  onChange: noop,
-};
-
 export default CheckboxColumn;
diff --git a/src/views/LostItems/LostItemsListContainer/components/LostItemsList/components/InstanceDetails/components/ShowLongContentInPopover/ShowLongContentInPopover.js b/src/views/LostItems/LostItemsListContainer/components/LostItemsList/components/InstanceDetails/components/ShowLongContentInPopover/ShowLongContentInPopover.js
index c04f3674d..6da93ff52 100644
--- a/src/views/LostItems/LostItemsListContainer/components/LostItemsList/components/InstanceDetails/components/ShowLongContentInPopover/ShowLongContentInPopover.js
+++ b/src/views/LostItems/LostItemsListContainer/components/LostItemsList/components/InstanceDetails/components/ShowLongContentInPopover/ShowLongContentInPopover.js
@@ -34,8 +34,8 @@ export const getComponentText = (text, additionalText = defaultAdditionalText, c
 
 const ShowLongContentInPopover = ({
   text,
-  additionalText,
-  contentLength,
+  additionalText = defaultAdditionalText,
+  contentLength = defaultContentLength,
 }) => {
   const {
     contentText,
@@ -61,9 +61,4 @@ ShowLongContentInPopover.propTypes = {
   contentLength: PropTypes.number,
 };
 
-ShowLongContentInPopover.defaultProps = {
-  additionalText: defaultAdditionalText,
-  contentLength: defaultContentLength,
-};
-
 export default ShowLongContentInPopover;