Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing SingleValueHydratedProperty and CollectionH.P. #2

Open
Tomucha opened this issue Feb 26, 2017 · 0 comments
Open

Consider removing SingleValueHydratedProperty and CollectionH.P. #2

Tomucha opened this issue Feb 26, 2017 · 0 comments
Assignees

Comments

@Tomucha
Copy link
Contributor

Tomucha commented Feb 26, 2017

... in favour of simple HydratedProperty which technically would be CollectionH.P, so you will always return a collection of keys ... for example Collections.singletonList(key).

Current separation is little bit confusing - I followed the API, created HydratedProperty and nothing happened. My suggested API will be more intuitive.

(Definitelly throw some exception in hydrator, if property isn't neither SingleValueHydratedProperty nor CollectionHP.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants