Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of range issue #20

Open
kstppd opened this issue Mar 16, 2022 · 3 comments
Open

Out of range issue #20

kstppd opened this issue Mar 16, 2022 · 3 comments

Comments

@kstppd
Copy link

kstppd commented Mar 16, 2022

&(temp_result[0]),

I have gotten a few out of range crashes here. I believe these should use the .data() method instead of &(vec[0]) to retrieve the memory location even when some of those vectors are empty. I also think there should be a general effort to change the rest of the instances as well. Should I create a PR with that?

@iljah
Copy link
Contributor

iljah commented Mar 17, 2022

Doesn't look like my email did anything so replying here:
Sure but please make it against master branch if possible, thanks!

@kstppd
Copy link
Author

kstppd commented Mar 17, 2022

Roger

@iljah
Copy link
Contributor

iljah commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants