Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document AWS SM #6287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document AWS SM #6287

wants to merge 1 commit into from

Conversation

bra-fsn
Copy link

@bra-fsn bra-fsn commented Feb 27, 2025

Tracking issue

Closes #6286

Why are the changes needed?

The current documentation is lacking on this topic.

What changes were proposed in this pull request?

Minimal documentation to enable and use AWS SM.

How was this patch tested?

NA

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • [ * ] I updated the documentation accordingly.
  • [ * ] All new and existing tests passed.
  • [ * ] All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Attila Nagy <[email protected]>
@bra-fsn bra-fsn requested a review from ppiegaze as a code owner February 27, 2025 21:35
Copy link

welcome bot commented Feb 27, 2025

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.82%. Comparing base (37386ba) to head (b5bb4ca).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6287   +/-   ##
=======================================
  Coverage   33.82%   33.82%           
=======================================
  Files        1329     1329           
  Lines      147808   147808           
=======================================
  Hits        49999    49999           
  Misses      92967    92967           
  Partials     4842     4842           
Flag Coverage Δ
unittests-datacatalog 48.01% <ø> (ø)
unittests-flyteadmin 50.11% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 58.09% <ø> (ø)
unittests-flyteidl 6.78% <ø> (ø)
unittests-flyteplugins 49.01% <ø> (ø)
unittests-flytepropeller 36.52% <ø> (ø)
unittests-flytestdlib 50.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Setting up and using AWS Secrets Manager is not straightforward
3 participants