From 122d1c2a7132eea784cc60f1db98185ad3934a78 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Pedro=20Oliveira?= Date: Tue, 17 Sep 2024 18:25:14 +0100 Subject: [PATCH 1/4] fix: don't show this again toggle bug #460 --- src/renderer/components/Modal/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/components/Modal/index.tsx b/src/renderer/components/Modal/index.tsx index a5148ae3..ac6007ea 100644 --- a/src/renderer/components/Modal/index.tsx +++ b/src/renderer/components/Modal/index.tsx @@ -272,7 +272,7 @@ interface DoNotAskAgainProps { } const DoNotAskAgain: FC = ({ checked, toggleChecked }) => ( -
+
Don't show this again From 17a967b190c77713f74de0521a4fcef3df45884a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Pedro=20Oliveira?= Date: Thu, 26 Sep 2024 11:19:57 +0100 Subject: [PATCH 2/4] updated changelog --- .github/CHANGELOG.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/CHANGELOG.yaml b/.github/CHANGELOG.yaml index a006a602..98f181ca 100644 --- a/.github/CHANGELOG.yaml +++ b/.github/CHANGELOG.yaml @@ -9,6 +9,11 @@ releases: + - name: 3.4.2 + changes: + - title: Fixed "show this again" toggle button on installer + categories: [UI] + authors: [JoaoOliveira85] - name: 3.4.1 changes: - title: Update installer default data for addon sources From fa9397e3e7f777caa74798c56cca653e48fe67ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Pedro=20Oliveira?= Date: Wed, 2 Oct 2024 23:54:50 +0100 Subject: [PATCH 3/4] Update .github/CHANGELOG.yaml Co-authored-by: Florian Scheuner --- .github/CHANGELOG.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CHANGELOG.yaml b/.github/CHANGELOG.yaml index 98f181ca..a749a545 100644 --- a/.github/CHANGELOG.yaml +++ b/.github/CHANGELOG.yaml @@ -11,7 +11,7 @@ releases: - name: 3.4.2 changes: - - title: Fixed "show this again" toggle button on installer + - title: Fixed "Don't show this again" toggle button categories: [UI] authors: [JoaoOliveira85] - name: 3.4.1 From 2c10ef471b46b42101b9b3c4df81de240f02acfe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Pedro=20Oliveira?= Date: Wed, 23 Oct 2024 22:45:34 +0100 Subject: [PATCH 4/4] fix: implemented pr review suggestion --- src/renderer/components/Modal/AutostartDialog.tsx | 3 ++- src/renderer/components/Modal/index.tsx | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/renderer/components/Modal/AutostartDialog.tsx b/src/renderer/components/Modal/AutostartDialog.tsx index 38bb2220..5b9b97c7 100644 --- a/src/renderer/components/Modal/AutostartDialog.tsx +++ b/src/renderer/components/Modal/AutostartDialog.tsx @@ -109,6 +109,7 @@ export const CompactYesNoOptionToggle: FC = ({ children, }) => { const handleClick = onToggle; + const voidFunction = () => {}; const borderColor = enabled ? 'border-cyan' : 'border-navy-light'; const titleColor = enabled ? 'text-cyan' : 'text-quasi-white'; @@ -118,7 +119,7 @@ export const CompactYesNoOptionToggle: FC = ({ className={`flex items-center gap-x-6 border-2 ${borderColor} transition-color cursor-pointer rounded-md px-6 py-5 duration-200`} onClick={handleClick} > - + {children} diff --git a/src/renderer/components/Modal/index.tsx b/src/renderer/components/Modal/index.tsx index ac6007ea..a5148ae3 100644 --- a/src/renderer/components/Modal/index.tsx +++ b/src/renderer/components/Modal/index.tsx @@ -272,7 +272,7 @@ interface DoNotAskAgainProps { } const DoNotAskAgain: FC = ({ checked, toggleChecked }) => ( -
+
Don't show this again