From 1bd0aa17c1b9fbe3277544c0221ee72a8d25625f Mon Sep 17 00:00:00 2001
From: Heclak <46121009+heclak@users.noreply.github.com>
Date: Thu, 12 Dec 2024 21:17:32 +0800
Subject: [PATCH] fix(a380x): make FO seat switches momentary

* fix FO seat switches timings to be momentary
* standardise both seats to have the same animation timings

Fixes #8948 , Fixes #9307
---
 .github/CHANGELOG.md                          |  1 +
 .../model/behaviour/interactive-parts.xml     | 20 +++++++++----------
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/.github/CHANGELOG.md b/.github/CHANGELOG.md
index affacd06b5f..5722fe148d3 100644
--- a/.github/CHANGELOG.md
+++ b/.github/CHANGELOG.md
@@ -87,6 +87,7 @@
 1. [A380X/SD] Add brake temperature color change to amber when brakes are hot - @heclak (Heclak)
 1. [A380X/FCU] Fix display of values on FCU during light test - @heclak (Heclak)
 1. [A380X/FMS] Fix VLS computation error for CONF 1, might have lead to FMS crashes during climb out - @flogross89 (floridude)
+1. [A380X] Fix FO seat switches not being momentary - @heclak (Heclak)
 
 ## 0.12.0
 
diff --git a/fbw-a380x/src/base/flybywire-aircraft-a380-842/SimObjects/AirPlanes/FlyByWire_A380_842/model/behaviour/interactive-parts.xml b/fbw-a380x/src/base/flybywire-aircraft-a380-842/SimObjects/AirPlanes/FlyByWire_A380_842/model/behaviour/interactive-parts.xml
index a7f7da35713..de40424ee96 100755
--- a/fbw-a380x/src/base/flybywire-aircraft-a380-842/SimObjects/AirPlanes/FlyByWire_A380_842/model/behaviour/interactive-parts.xml
+++ b/fbw-a380x/src/base/flybywire-aircraft-a380-842/SimObjects/AirPlanes/FlyByWire_A380_842/model/behaviour/interactive-parts.xml
@@ -264,13 +264,13 @@
                 <ANIM_NAME>SEAT_CPT_MOVE_FWD_AFT_CLICK</ANIM_NAME>
                 <SWITCH_POSITION_TYPE>L</SWITCH_POSITION_TYPE>
                 <SWITCH_POSITION_VAR>XMLVAR_SEAT_FWDAFT</SWITCH_POSITION_VAR>
-                <MOMENTARY_REPEAT_FREQUENCY>800</MOMENTARY_REPEAT_FREQUENCY>
+                <MOMENTARY_REPEAT_FREQUENCY>400</MOMENTARY_REPEAT_FREQUENCY>
                 <CODE_POS_0>(L:A32NX_ELEC_AC_2_BUS_IS_POWERED, Bool) if{
-                    (L:SEAT_CPT_MOVE_FWD_AFT) 0.4 + 100 min (&gt;L:SEAT_CPT_MOVE_FWD_AFT)
+                    (L:SEAT_CPT_MOVE_FWD_AFT) 0.2 + 100 min (&gt;L:SEAT_CPT_MOVE_FWD_AFT)
                 }
                 </CODE_POS_0>
                 <CODE_POS_2>(L:A32NX_ELEC_AC_2_BUS_IS_POWERED, Bool) if{
-                    (L:SEAT_CPT_MOVE_FWD_AFT) 0.4 - 0 max (&gt;L:SEAT_CPT_MOVE_FWD_AFT)
+                    (L:SEAT_CPT_MOVE_FWD_AFT) 0.2 - 0 max (&gt;L:SEAT_CPT_MOVE_FWD_AFT)
                 }
                 </CODE_POS_2>
                 <MOMENTARY_SWITCH/>
@@ -293,13 +293,13 @@
                 <ANIM_NAME>SEAT_CPT_MOVE_UP_DOWN_CLICK</ANIM_NAME>
                 <SWITCH_POSITION_TYPE>L</SWITCH_POSITION_TYPE>
                 <SWITCH_POSITION_VAR>XMLVAR_SEAT_UPDOWN</SWITCH_POSITION_VAR>
-                <MOMENTARY_REPEAT_FREQUENCY>800</MOMENTARY_REPEAT_FREQUENCY>
+                <MOMENTARY_REPEAT_FREQUENCY>400</MOMENTARY_REPEAT_FREQUENCY>
                 <CODE_POS_0>(L:A32NX_ELEC_AC_2_BUS_IS_POWERED, Bool) if{
-                    (L:SEAT_CPT_MOVE_UP_DOWN) 0.4 + 100 min (&gt;L:SEAT_CPT_MOVE_UP_DOWN)
+                    (L:SEAT_CPT_MOVE_UP_DOWN) 0.2 + 100 min (&gt;L:SEAT_CPT_MOVE_UP_DOWN)
                 }
               	</CODE_POS_0>
                 <CODE_POS_2>(L:A32NX_ELEC_AC_2_BUS_IS_POWERED, Bool) if{
-                    (L:SEAT_CPT_MOVE_UP_DOWN) 0.4 - 0 max (&gt;L:SEAT_CPT_MOVE_UP_DOWN)
+                    (L:SEAT_CPT_MOVE_UP_DOWN) 0.2 - 0 max (&gt;L:SEAT_CPT_MOVE_UP_DOWN)
                 }
                 </CODE_POS_2>
                 <MOMENTARY_SWITCH/>
@@ -390,8 +390,8 @@
                 </CODE_POS_2>
                 <MOMENTARY_SWITCH/>
 				<ANIM_LAG>800</ANIM_LAG>
-                <STATE_MAX_TIMER>2</STATE_MAX_TIMER>
-                <STATE0_TIMER>2</STATE0_TIMER>
+                <STATE_MAX_TIMER>0.2</STATE_MAX_TIMER>
+                <STATE0_TIMER>0.2</STATE0_TIMER>
                 <SWITCH_DIRECTION>Horizontal</SWITCH_DIRECTION>
 				<INVERT_ANIM>1</INVERT_ANIM>
             </UseTemplate>
@@ -420,8 +420,8 @@
                 </CODE_POS_2>
                 <MOMENTARY_SWITCH/>
 				<ANIM_LAG>800</ANIM_LAG>
-                <STATE_MAX_TIMER>2</STATE_MAX_TIMER>
-                <STATE0_TIMER>2</STATE0_TIMER>
+                <STATE_MAX_TIMER>0.2</STATE_MAX_TIMER>
+                <STATE0_TIMER>0.2</STATE0_TIMER>
                 <SWITCH_DIRECTION>Vertical</SWITCH_DIRECTION>
 				<INVERT_ANIM>1</INVERT_ANIM>
             </UseTemplate>