Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x): Consider .flt file loading state for WASM startup #9586

Closed
wants to merge 18 commits into from

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Nov 24, 2024

Summary of Changes

Changes the startup and initialization phase for A32NX and A380X, which hopefully solves some problems for MSFS2024.
Now, A32NX_IS_READY is only set when the FLT file has been fully loaded.

Screenshots (if necessary)

References

FBW Startup (4)

Additional context

Discord username (if different from GitHub):

Testing instructions

MSFS2020 and MSFS2024: Load aircraft in different scenarios (apron, runway, in flight) and verify that the plane spawns as expected.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 added the MSFS2024 PRs Fixing FS2024 Issues label Nov 24, 2024
@tracernz
Copy link
Member

I think it's a bit dangerous to ignore SimConnect messages like that, and will lead to confusing bugs. Loading .flt files will not work correctly for instance if we've intercepted/blocked a key event that's used to load the .flt file, and then ignored the event message.

@flogross89
Copy link
Contributor Author

I think it's a bit dangerous to ignore SimConnect messages like that, and will lead to confusing bugs. Loading .flt files will not work correctly for instance if we've intercepted/blocked a key event that's used to load the .flt file, and then ignored the event message.

Which change is this comment referring to?

@tracernz
Copy link
Member

tracernz commented Dec 8, 2024

This one 7b714de

@flogross89
Copy link
Contributor Author

This one 7b714de

Ah ok, didn't find another way to do it, and it's also hugely inefficient for me to spend time on solving these Rust environment issues. Happy to have some of the Rust folks have a look at it

@flogross89
Copy link
Contributor Author

Doesn't seem to be needed anymore

@flogross89 flogross89 closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MSFS2024 PRs Fixing FS2024 Issues Waiting on Core Decision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants