Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/fadec): N1 fan protection measures (METOTS, KOZ) #9481

Merged
merged 15 commits into from
Nov 20, 2024

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Nov 11, 2024

Fixes #9283

Summary of Changes

Implements METOTS and KOZ (keep-out zone) in the N1 control loop within the Autothrust.
Additionally, adds temporary provisions to draw the grey area (avail thrust) only until the METOTS area below CAS of 35kts. Once we have proper FADEC, this should be replaced by SimVars communicating the current min. and max. avail thrust.

The reverse thrust limit changes are from #9417

Screenshots (if necessary)

References

Additional context

image

image

Discord username (if different from GitHub):

Testing instructions

  1. Perform TO/GA takeoff, below 35kts the thrust should be limited to 78% N1 max.
  2. Perform FLX takeoff, below 35kts the thrust should be limited to 78% N1 max.
  3. Ensure that the full range of thrust is available in normal flight

Below 35kts, it shouldn't be possible to command N1 > 78%
Below 60kts, it shouldn't be possible to command N1 between 64% and 72%

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Nov 11, 2024
@flogross89 flogross89 requested a review from aguther November 11, 2024 01:14
@Tankman61
Copy link

Tankman61 commented Nov 11, 2024

I've just been testing myself and it looks good, just a few small things to ask. I don't know if they really matter/are intentional/fixable but here they are:

  • Whenever I spawn into the aircraft on the runway and push the throttle levers to TOGA I'm able to bring the engines to 100% N1 temporarily before they go back down to 76.5% N1
  • The grey area is slightly greater than the maximum commanded N1 possible (76.5%)
  • I'm able to get the engines to above 76.5% N1 but no greater than 78% N1 when I put the thrust levers between climb and idle while under 35 knots of airspeed

I can upload screenshots if needed but these are relatively minor

@2hwk 2hwk added QA Tier 1 and removed QA A380 Only QA only for A380 required labels Nov 11, 2024
@flogross89
Copy link
Contributor Author

@Tankman61 Thank you! Could you please provide a video for 1) and 3)? Maybe there's a condition or case I missed.

@Tankman61
Copy link

Tankman61 commented Nov 11, 2024

Here's a screenshot for 3, I have a video on another device which I will upload when I get home but it was really easy to reproduce, all you do is spawn in on a runway at an airport and immediately set the thrust levers to toga. As the engines spool up they will reach 100% N1 for a few seconds before reducing back to 76.5% N1.
Screenshot 2024-11-11 145520
edit: video

2024-11-10.21-18-24.mp4

@flogross89
Copy link
Contributor Author

@Tankman61 Thanks! This only happens when spawning on the runway and setting TOGA immediately, right? We likely have some internal confirmation circuits for the ground condition and some startup timing stuff, that's why it probably takes 5-10s after startup of all components to behave correctly. This is expected, as this use case of spawning and insta-TOGA is highly unrealistic :)

@alexr4339
Copy link

Quality Assurance Tester

Discord Username : alexdnzdmb
Object of testing : #9481
Aircraft : A380X
Tier of Testing : 1
Date : 15/11/2024

Testing Process:
Perform TO/GA takeoff, below 35kts the thrust should be limited to 78% N1 max. - working, N1 around 76,5%
Perform FLX takeoff, below 35kts the thrust should be limited to 78% N1 max. - working, N1 around 76,5%
Ensure that the full range of thrust is available in normal flight - it is
Below 35kts, it shouldn't be possible to command N1 > 78% - working, N1 around 76,5%
Below 60kts, it shouldn't be possible to command N1 between 64% and 72% - working, N1 around 62,5% so not right at the edge

Testing Results:
Passed

Negatives:
None

Conclusions:
Great addition

Media:

# Conflicts:
#	fbw-a380x/src/systems/instruments/src/EWD/shared/EwdSimvarPublisher.tsx
@2hwk 2hwk removed the QA Passed label Nov 16, 2024
@2hwk 2hwk added this to the v0.13.0 milestone Nov 16, 2024
@flogross89 flogross89 enabled auto-merge (squash) November 20, 2024 21:30
@flogross89 flogross89 merged commit 20b8db1 into flybywiresim:master Nov 20, 2024
8 checks passed
@flogross89 flogross89 deleted the feat-a380x-metots branch November 20, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA Passed QA Tier 1
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

Implement METOTS system for A380X
5 participants