Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change context type to all lowercase #9

Open
Nash0x7E2 opened this issue Mar 18, 2020 · 5 comments
Open

Change context type to all lowercase #9

Nash0x7E2 opened this issue Mar 18, 2020 · 5 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@Nash0x7E2
Copy link
Contributor

Is it possible to update all collective types to lowercase?

@Nash0x7E2 Nash0x7E2 added bug Something isn't working documentation Improvements or additions to documentation labels Mar 18, 2020
@orestesgaolin
Copy link

Or ignore case altogether :)

@jdeepee
Copy link
Member

jdeepee commented Mar 19, 2020

@Nash0x7E2 @orestesgaolin what is the motivation for doing this? The type return types are currently derived directly from rust our types. If I were to go for lowercase I would have to declare and implement a trait on all of the types that are currently returned. Not hard but a little annoying to add.

@orestesgaolin
Copy link

@jdeepee it's a bit annoying on our part.

The motivation for this exact one was that we want to have enum for collective types which in Dart should be lowercase. This would allow us to automatically generate string representation of the enum without manually changing letter case.

@jdeepee
Copy link
Member

jdeepee commented Mar 19, 2020

Hahah so we are in the same situation. Do you currently have a solution for interpreting these strings into an enum or is that still to be built?

@orestesgaolin
Copy link

We enforced Capital Case Enum here so it's partially solved, but it's against Dart rules. It took us a long time to figure out that the reason for http error is wrong case of the query parameter value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants