Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharding not possible across namespaces #188

Open
drewwells opened this issue Sep 19, 2023 · 2 comments · May be fixed by #190
Open

Sharding not possible across namespaces #188

drewwells opened this issue Sep 19, 2023 · 2 comments · May be fixed by #190
Labels
bug Something isn't working

Comments

@drewwells
Copy link

Describe the bug a clear and concise description of what the bug is.

Cluster resources for RBAC are created with static names, but references namespace specific resources. Given a situation where I install flux into two namespaces a and b. The clusterrolebinding mentions the a/serviceaccount. When I go to install b it attempts to create the same clusterrolebinding but mentions b/serviceaccount.

The simple fix is to include the release name in all cluster wide rbac objects.

What's your helm version?

n/a

What's your kubectl version?

n/a

What's the chart version?

2.9.2

What happened?

No response

What you expected to happen?

No response

How to reproduce it?

Install the chart twice in the same cluster into two separate namespaces.

Enter the changed values of values.yaml?

No response

Enter the command that you execute and failing/misfunctioning.

helm install ... normal steps.

Anything else we need to know?

No response

@drewwells drewwells added the bug Something isn't working label Sep 19, 2023
@stefanprodan
Copy link
Member

Flux sharding is not supported by the chart, also deploying to separate namespaces is not how sharding should work. The chart needs to replicate this config: https://fluxcd.io/flux/installation/configuration/sharding/

@drewwells
Copy link
Author

I'm using sharding just fine with this chart. I'll submit a PR to remedy this bug.

drewwells added a commit to drewwells/fluxcd-helm-charts that referenced this issue Sep 20, 2023
@drewwells drewwells linked a pull request Sep 20, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants