Skip to content

RFC 14: add a 'bank' field to jobspec? #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmoussa1 opened this issue Aug 26, 2020 · 3 comments
Closed

RFC 14: add a 'bank' field to jobspec? #262

cmoussa1 opened this issue Aug 26, 2020 · 3 comments
Labels

Comments

@cmoussa1
Copy link
Member

I'm sorry in advance if this is not the right RFC to reference!

I opened an issue in flux-framework/flux-core #3136 that discussed some of the gaps when trying to create job usage reports. One of the fields needed is a bank field, a field that stores what bank the user charged their job against (filtering job records by bank was one of the features discussed with Ryan Day). @grondo left this feedback in that thread:

We'll need to determine a spot where the group/account gets set in jobspec. Then you can pull it from there, or it may be important enough to add to job-info and perhaps broken out as a separate key in job-archive?
We may want to open an issue on this in the rfc repo.

Does it make sense to place a bank field in jobspec? I assume that a bank would be an option passed in by the user when submitting a job, and it defaults to some bank if nothing is passed in:

$ flux mini submit --bank=this_specific_bank -n 1 hostname

From a flux-accounting perspective, I tried to think of ways to pull the same information directly from the flux-accounting database without needing to include it in jobspec. I first thought that a lookup could be performed with the username passed in to see which bank the user belongs in, but one issue that comes to mind is the possibility that a user belongs to multiple banks... so, would there instead to be a lookup in the flux-accounting database performed immediately after a job is submitted to validate which bank was specified?

@SteVwonder
Copy link
Member

Does it make sense to place a bank field in jobspec? I assume that a bank would be an option passed in by the user when submitting a job, and it defaults to some bank if nothing is passed in:

👍 Makes sense to me. Maybe under attributes.system.bank?

@dongahn
Copy link
Member

dongahn commented Sep 1, 2020

@cmoussa1:

Please see how we add "queue" info into job spec:

https://github.com/flux-framework/flux-sched/blob/master/t/t1009-recovery-multiqueue.t#L29

At some point, we can take a deeper look at the scheduler-specific data schema like queue and bank. But for now, what @SteVwonder suggested makes sense to me.

@garlick
Copy link
Member

garlick commented Nov 12, 2024

Fixed by #420

@garlick garlick closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants