Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image suffix mismatch in description #11542

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zm999999
Copy link

@zm999999 zm999999 commented Dec 25, 2024

Fix image suffix mismatch in description

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

Fix image suffix mismatch in description
@zm999999 zm999999 requested review from sfshaza2, parlough and a team as code owners December 25, 2024 09:33
Copy link

google-cla bot commented Dec 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Use the correct image suffix from the code example (examples/get-started/flutter-for/android_devs/lib/images.dart)
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this! I see there's still a few other png suffix examples remaining.

What do you think about updating them all to .png? I think that's likely the more common file type.

@zm999999
Copy link
Author

@parlough Thank you for pointing that out! I will update the examples to .png.

@zm999999 zm999999 requested a review from parlough December 26, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants