Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set-up-app-links.md (add missing line) #11526

Closed
wants to merge 1 commit into from

Conversation

Reza-Babakhani
Copy link

<meta-data android:name="flutter_deeplinking_enabled" android:value="true" />

This one line of code took me 3 days.
Without this, deep linking doesn't work.

This one line of code took me 3 days.
Without this, deep linking doesn't work.
@Reza-Babakhani Reza-Babakhani requested review from sfshaza2, parlough and a team as code owners December 20, 2024 13:57
Copy link

google-cla bot commented Dec 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@parlough
Copy link
Member

Thanks for the PR to fix this and sorry about the confusion you met. I'll defer to others to review:

@chunhtai or @hannah-hyj would you mind taking a look at this PR? Thank you!

@hannah-hyj
Copy link
Member

hannah-hyj commented Dec 26, 2024

@Reza-Babakhani Sorry for the confusion you encountered and thank you for filing this.

Starting from Flutter version 3.27 ( the latest stable) , the deep link flag is set to true by default, so this line is no longer needed.
However, for Flutter versions earlier than 3.27, this line is still necessary.

I think we should add back this line, but include it as a note:
"If you are using a Flutter version earlier than 3.27, add the following metadata tag:
<meta-data android:name="flutter_deeplinking_enabled" android:value="true" />

the iOS setup guide should be updated as well, same situation with the flag for iOS. I can do that in a separate PR.

Thank you for reminding us of this. The latest stable version was just launched, and most users are still on earlier versions, so adding back this line to the guide is essential.

hannah-hyj added a commit that referenced this pull request Jan 6, 2025
)

Follow up on #11526.

This PR added a note for flutter version earlier than 3.27, you need to
manually add code to opt-in to flutter deep link.

Related PR: #11461.

---------

Co-authored-by: Parker Lougheed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants