Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android][Impeller] Plugin migration for SurfaceProducer contains a bad link for the flowchart #11508

Open
1 task
navaronbracke opened this issue Dec 17, 2024 · 1 comment
Open
1 task

[Android][Impeller] Plugin migration for SurfaceProducer contains a bad link for the flowchart #11508

navaronbracke opened this issue Dec 17, 2024 · 1 comment
Assignees
@matanlurey
Labels
e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@navaronbracke
Copy link
Contributor

Page URL

https://docs.flutter.dev/release/breaking-changes/android-surface-plugins#background

Page source

No response

Describe the problem

The flowchart in the Background section seems to not render, due to a broken link?

The link itself points to https://camo.githubusercontent.com/cdb52c5d371b4f1d5573b650a0eddb0871e5e8be1012d290e008f41bc71b2580/68747470733a2f2f736f757263652e616e64726f69642e636f6d2f7374617469632f646f63732f636f72652f67726170686963732f696d616765732f636f6e74696e756f75735f636170747572655f61637469766974792e706e67

We probably need to put the flowchart in the assets for the API docs?

Screenshot 2024-12-17 at 08 46 02

Expected fix

The link to the flowchart should be updated, so that it is displayed correctly.

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on docs.flutter.dev.
@navaronbracke navaronbracke added the from.page-issue Reported in a reader-filed concern label Dec 17, 2024
@sfshaza2
Copy link
Contributor

@matanlurey, can you take a look?

@sfshaza2 sfshaza2 added p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Effort: < 8 hrs labels Dec 17, 2024
@matanlurey matanlurey self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matanlurey matanlurey

Labels
e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matanlurey @navaronbracke @sfshaza2