Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column widget in FinishedPage and WaitingPage has been wrapped by Sing… #11247

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Column widget in FinishedPage and WaitingPage has been wrapped by Sing… #11247

wants to merge 8 commits into from

Conversation

tbansod2018
Copy link
Contributor

@tbansod2018 tbansod2018 commented Oct 8, 2024 •
edited
Loading

…leChildScrollView to avoid overflow

Description of what this PR is changing or adding, and why:
Column Widget in FinishedPage and WaitingPage has been wraped by SingleChildScrollView to avoid overflow.

Issues fixed by this PR (if any): Fixes #11220

PRs or commits this PR depends on (if any):

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@tbansod2018 tbansod2018 requested review from sfshaza2, parlough and a team as code owners October 8, 2024 18:42
@sfshaza2
Copy link
Contributor

sfshaza2 commented Oct 9, 2024

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit a8180ba):

https://flutter-docs-prod--pr11247-main-gdgm6ks7.web.app

@sfshaza2
Copy link
Contributor

sfshaza2 commented Oct 9, 2024

@tbansod2018, the test check is failing. If you click on the Details, it asks you to run ./dash_site refresh-excerpts to make sure the code excerpts are up to date.

@ericwindmill, I've confirmed that the DartPad example works on https://flutter-docs-prod--pr11247-main-gdgm6ks7.web.app/cookbook/effects/nested-nav, but can you review the code?

ericwindmill
ericwindmill requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@ericwindmill ericwindmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbansod2018 The code looks good. But as @sfshaza2 said, you need to update the excerpts with the ./dash_site refresh-excerpts command. More details are in the README

@sfshaza2 sfshaza2 changed the title Column widget in FinishedPage and WaitingPage has been wraped by Sing… Column widget in FinishedPage and WaitingPage has been wrapped by Sing… Oct 11, 2024
@sfshaza2 sfshaza2 added the act.wait-for-customer Needs response from customer label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 Awaiting requested review from sfshaza2

@parlough parlough Awaiting requested review from parlough

@ericwindmill ericwindmill Awaiting requested review from ericwindmill

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
act.wait-for-customer Needs response from customer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

broken demo
4 participants
@tbansod2018 @sfshaza2 @flutter-website-bot @ericwindmill