Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shared_preferences] Remove BigInt and Set<String> support from Android implementation #124420

Open
stuartmorgan opened this issue Apr 7, 2023 · 1 comment · May be fixed by flutter/packages#8335
Open

[shared_preferences] Remove BigInt and Set<String> support from Android implementation #124420

stuartmorgan opened this issue Apr 7, 2023 · 1 comment · May be fixed by flutter/packages#8335
Labels
p: requires breaking change A change that should be batched into the next breaking change to this package p: shared_preferences Plugin to read and write Shared Preferences P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team

Comments

@stuartmorgan
Copy link
Contributor

There's code in the Android implementation from many years ago that supported storing and retrieving BigInteger values. But since at least January 2018 it hasn't been possible to save such a value. We're going to remove the dead code for setting it, but technically removing the reading code is breaking since someone could, in theory, have a 6 year old pref that they are reading as a string (and have never written again?)

The next time we are doing a breaking change to shared_preferences for any other reason, we should remove that code.
@stuartmorgan stuartmorgan added p: shared_preferences Plugin to read and write Shared Preferences package flutter/packages repository. See also p: labels. P3 Issues that are less important to the Flutter project p: requires breaking change A change that should be batched into the next breaking change to this package labels Apr 7, 2023
@stuartmorgan stuartmorgan changed the title [shared_preferences] Remove BigInt support from Android implementation [shared_preferences] Remove BigInt and Set<String> support from Android implementation Apr 11, 2023
@stuartmorgan
Copy link
Contributor Author

There's also code for Set<String> prefs; they haven't been settable in many years, and they migrate on read, so chances are vanishingly small that anything still needs it; we should remove that code in the same breaking change.

@stuartmorgan stuartmorgan mentioned this issue Apr 11, 2023
Merged
@flutter-triage-bot flutter-triage-bot bot added team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team labels Jul 8, 2023
@tarrinneal tarrinneal linked a pull request Dec 20, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: requires breaking change A change that should be batched into the next breaking change to this package p: shared_preferences Plugin to read and write Shared Preferences P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team
Projects
None yet
Milestone
No milestone
1 participant
@stuartmorgan