From b7cb2625b866c9d273f95d386c01c980a9af5910 Mon Sep 17 00:00:00 2001
From: Christian Uldall Pedersen <cup@gamblify.com>
Date: Wed, 10 Jul 2024 21:10:08 +0200
Subject: [PATCH] [webview_flutter_web] Add support for the credentialless
 attribute. (#151557)

---
 .../webview_flutter_web/example/lib/main.dart |  2 +-
 .../lib/src/web_webview_controller.dart       | 25 +++++++++++++------
 .../test/web_webview_controller_test.dart     | 10 ++++++++
 3 files changed, 28 insertions(+), 9 deletions(-)

diff --git a/packages/webview_flutter/webview_flutter_web/example/lib/main.dart b/packages/webview_flutter/webview_flutter_web/example/lib/main.dart
index 9ce006031279..9686f8667c27 100644
--- a/packages/webview_flutter/webview_flutter_web/example/lib/main.dart
+++ b/packages/webview_flutter/webview_flutter_web/example/lib/main.dart
@@ -24,7 +24,7 @@ class _WebViewExample extends StatefulWidget {
 
 class _WebViewExampleState extends State<_WebViewExample> {
   final PlatformWebViewController _controller = PlatformWebViewController(
-    const PlatformWebViewControllerCreationParams(),
+    WebWebViewControllerCreationParams(),
   )..loadRequest(
       LoadRequestParams(
         uri: Uri.parse('https://flutter.dev'),
diff --git a/packages/webview_flutter/webview_flutter_web/lib/src/web_webview_controller.dart b/packages/webview_flutter/webview_flutter_web/lib/src/web_webview_controller.dart
index 2d8297fb5fd5..a5b2e7967adf 100644
--- a/packages/webview_flutter/webview_flutter_web/lib/src/web_webview_controller.dart
+++ b/packages/webview_flutter/webview_flutter_web/lib/src/web_webview_controller.dart
@@ -18,19 +18,32 @@ import 'http_request_factory.dart';
 @immutable
 class WebWebViewControllerCreationParams
     extends PlatformWebViewControllerCreationParams {
-  /// Creates a new [AndroidWebViewControllerCreationParams] instance.
+  /// Creates a new [WebWebViewControllerCreationParams] instance.
+  /// [iFrameCredentialless] can be used to set the credentialless attribute on the <iframe>.
   WebWebViewControllerCreationParams({
     @visibleForTesting this.httpRequestFactory = const HttpRequestFactory(),
-  }) : super();
+    bool iFrameCredentialless = false,
+  })  : iFrame = web.HTMLIFrameElement()
+          ..id = 'webView${_nextIFrameId++}'
+          ..style.width = '100%'
+          ..style.height = '100%'
+          ..style.border = 'none'
+          ..setAttribute(
+              'credentialless', iFrameCredentialless ? 'true' : 'false'),
+        super();
 
   /// Creates a [WebWebViewControllerCreationParams] instance based on [PlatformWebViewControllerCreationParams].
+  /// [iFrameCredentialless] can be used to set the credentialless attribute on the <iframe>.
   WebWebViewControllerCreationParams.fromPlatformWebViewControllerCreationParams(
     // Recommended placeholder to prevent being broken by platform interface.
     // ignore: avoid_unused_constructor_parameters
     PlatformWebViewControllerCreationParams params, {
     @visibleForTesting
     HttpRequestFactory httpRequestFactory = const HttpRequestFactory(),
-  }) : this(httpRequestFactory: httpRequestFactory);
+    bool iFrameCredentialless = false,
+  }) : this(
+            httpRequestFactory: httpRequestFactory,
+            iFrameCredentialless: iFrameCredentialless);
 
   static int _nextIFrameId = 0;
 
@@ -39,11 +52,7 @@ class WebWebViewControllerCreationParams
 
   /// The underlying element used as the WebView.
   @visibleForTesting
-  final web.HTMLIFrameElement iFrame = web.HTMLIFrameElement()
-    ..id = 'webView${_nextIFrameId++}'
-    ..style.width = '100%'
-    ..style.height = '100%'
-    ..style.border = 'none';
+  final web.HTMLIFrameElement iFrame;
 }
 
 /// An implementation of [PlatformWebViewController] using Flutter for Web API.
diff --git a/packages/webview_flutter/webview_flutter_web/test/web_webview_controller_test.dart b/packages/webview_flutter/webview_flutter_web/test/web_webview_controller_test.dart
index c7a7245279e2..13202355cbda 100644
--- a/packages/webview_flutter/webview_flutter_web/test/web_webview_controller_test.dart
+++ b/packages/webview_flutter/webview_flutter_web/test/web_webview_controller_test.dart
@@ -32,6 +32,16 @@ void main() {
         expect(params.iFrame.style.width, '100%');
         expect(params.iFrame.style.height, '100%');
         expect(params.iFrame.style.border, 'none');
+        expect(params.iFrame.attributes.getNamedItem('credentialless')!.value,
+            'false');
+      });
+
+      test('sets iFrame attribute credentialless', () {
+        final WebWebViewControllerCreationParams params =
+            WebWebViewControllerCreationParams(iFrameCredentialless: true);
+
+        expect(params.iFrame.attributes.getNamedItem('credentialless')!.value,
+            'true');
       });
     });