Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Benchmarks aren't running #903

Open
1 task done
guidezpl opened this issue Feb 17, 2023 · 1 comment
Open
1 task done

Benchmarks aren't running #903

guidezpl opened this issue Feb 17, 2023 · 1 comment
Labels
bug Something isn't working P2 Priority 2 - Should have

Comments

@guidezpl
Copy link
Member

Existing issue?

What happened?

Expected vs actual result:

Benchmarks can be run. In actuality,

  • in headless mode, the benchmark test hangs:
flutter test test_benchmarks/benchmarks_test.dart
Resolving dependencies... (1.2s)
  _fe_analyzer_shared 52.0.0 (53.0.0 available)
  analyzer 5.4.0 (5.5.0 available)
  args 2.3.2 (2.4.0 available)
  characters 1.2.1 (1.3.0 available)
  path_provider_linux 2.1.7 (2.1.8 available)
  source_maps 0.10.11 (0.10.12 available)
  test 1.23.0 (1.23.1 available)
  test_core 0.4.23 (0.4.24 available)
  vm_service 10.1.2 (11.0.1 available)
  win32 3.1.3 (4.1.1 available)
  xdg_directories 0.2.0+3 (1.0.0 available)
Got dependencies!
00:05 +0: Can run a web benchmark                                                                                                               Shell: Starting web benchmark tests ...
02:07 +0: Can run a web benchmark                                                                                                               
Launching Chrome.
Launching Google Chrome 110.0.5481.100 

Waiting for the benchmark to report benchmark profile.
[CHROME]: [0217/143403.783780:ERROR:socket_posix.cc(147)] bind() failed: Address already in use (48)
[CHROME]: [0217/143403.783864:ERROR:socket_posix.cc(147)] bind() failed: Address already in use (48)
[CHROME]: [0217/143403.783880:ERROR:devtools_http_handler.cc(310)] Cannot start http server for devtools.
[CHROME]: objc[74459]: Class WebSwapCGLLayer is implemented in both /System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks/libANGLE-shared.dylib (0x22c6c5518) and /Applications/Google Chrome.app/Contents/Frameworks/Google Chrome Framework.framework/Versions/110.0.5481.100/Libraries/libGLESv2.dylib (0x10a327b58). One of the two will be used. Which one is undefined.
[CHROME]: [0217/143403.844731:ERROR:simple_version_upgrade.cc(152)] Failed to write a new fake index.
[CHROME]: [0217/143403.845058:ERROR:simple_version_upgrade.cc(152)] Failed to write a new fake index.
[CHROME]: [0217/143403.845069:ERROR:simple_backend_impl.cc(738)] Simple Cache Backend: wrong file structure on disk: 8 path: /Users/plg/development/gallery/.dart_tool/chrome_user_data_4Jzwsa/Default/Cache/Cache_Data
[CHROME]: [0217/143403.845311:ERROR:disk_cache.cc(205)] Unable to create cache
[CHROME]: [0217/143404.269389:INFO:CONSOLE(165)] "Installing/Activating first service worker.", source: http://localhost:9999/flutter.js (165)
[CHROME]: [0217/143404.305194:INFO:CONSOLE(0)] "Uncaught (in promise) NetworkError: Cache.addAll() encountered a network error", source: http://localhost:9999/flutter_service_worker.js?v=3215449683 (0)
[CHROME]: [0217/143408.218448:INFO:CONSOLE(360)] "Exception while loading service worker: Error: prepareServiceWorker took more than 4000ms to resolve. Moving on.", source: http://localhost:9999/flutter.js (360)
[CHROME]: [0217/143408.218574:INFO:CONSOLE(304)] "Injecting <script> tag. Using Promises. Use the callback approach instead!", source: http://localhost:9999/flutter.js (304)
[CHROME]: [0217/143408.410500:INFO:CONSOLE(16996)] "Flutter Web Bootstrap: Programmatic.", source: http://localhost:9999/main.dart.js (16996)
  • in non-headless mode, it quits in between benchmark tests with the following error
Bad state: No element
  dart:core                                       Iterable.single
  package:web_benchmarks/src/browser.dart 294:30  _connectToChromeDebugPort

Once this is fixed, the benchmarks should be re-enabled.

Steps to reproduce:

With Google Chrome 110.0.5481.100, and flutter @ HEAD (exact version in logs), gallery @ HEAD

  1. flutter test test_benchmarks/benchmarks_test.dart

Relevant log output

flutter doctor -v
[!] Flutter (Channel constrain-dialogs, 3.8.0-12.0.pre.36, on macOS 13.2.1 22D68 darwin-arm64, locale en)
    • Flutter version 3.8.0-12.0.pre.36 on channel constrain-dialogs at /Users/plg/development/flutter-dev
    ! Upstream repository https://github.com/guidezpl/flutter.git is not a standard remote.
      Set environment variable "FLUTTER_GIT_URL" to https://github.com/guidezpl/flutter.git to dismiss this error.
    • Framework revision 7843c0e20d (4 days ago), 2023-02-13 14:24:44 +0100
    • Engine revision ede2a0a3c3
    • Dart version 3.0.0 (build 3.0.0-231.0.dev)
    • DevTools version 2.21.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks
      and upgrades.
@guidezpl guidezpl added bug Something isn't working triage labels Feb 17, 2023
@guidezpl guidezpl mentioned this issue Feb 17, 2023
@guidezpl guidezpl added P1 Priority 1 - Must have and removed triage labels Feb 17, 2023
@guidezpl
Copy link
Member Author

Related to flutter/flutter#59082

@guidezpl guidezpl changed the title Benchmarks don't run properly Benchmarks aren't running Jun 5, 2023
@guidezpl guidezpl added P2 Priority 2 - Should have and removed P1 Priority 1 - Must have labels Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working P2 Priority 2 - Should have
Projects
None yet
Development

No branches or pull requests

1 participant