Skip to content

Commit 62d4d2d

Browse files
authored
Fix DaemonCrashReporter dialog modality type (#8066)
The constructor we were invoking was defaulting to `IdeModalityType.PROJECT` which is not fully supported. Migrating to use `IdeModalityType.IDE` addresses this. (Verified on Meerkat.) Fixes: #7986 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read the [Flutter Style Guide] _recently_, and have followed its advice. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
1 parent c56d9fa commit 62d4d2d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

flutter-idea/src/io/flutter/run/daemon/DeviceDaemon.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ private static class DaemonCrashReporter extends DialogWrapper {
434434
private JTextPane myTextPane;
435435

436436
DaemonCrashReporter() {
437-
super(null, false, false);
437+
super(null, false, DialogWrapper.IdeModalityType.IDE);
438438
setTitle("Flutter Device Daemon Crash");
439439
myPanel = new JPanel();
440440
myTextPane = new JTextPane();

0 commit comments

Comments
 (0)