From 07b1d739925e841f74a1b6bfc7ef4a6265e44dc9 Mon Sep 17 00:00:00 2001 From: Remon Date: Wed, 18 Dec 2024 15:51:22 +0000 Subject: [PATCH] chore: review comments --- example/android/settings.gradle | 2 +- packages/stripe/README.md | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/example/android/settings.gradle b/example/android/settings.gradle index 5b43c09e..c66670a5 100644 --- a/example/android/settings.gradle +++ b/example/android/settings.gradle @@ -18,7 +18,7 @@ pluginManagement { plugins { id "dev.flutter.flutter-plugin-loader" version "1.0.0" - id "com.android.application" version "8.6.1" apply false + id "com.android.application" version "8.7.3" apply false id "org.jetbrains.kotlin.android" version "1.8.10" apply false } diff --git a/packages/stripe/README.md b/packages/stripe/README.md index e77555ba..cc9dac4d 100644 --- a/packages/stripe/README.md +++ b/packages/stripe/README.md @@ -60,16 +60,18 @@ This plugin requires several changes to be able to work on Android devices. Plea -dontwarn com.stripe.android.pushProvisioning.PushProvisioningActivityStarter -dontwarn com.stripe.android.pushProvisioning.PushProvisioningEphemeralKeyProvider ``` -8. Rebuild the app, as the above changes don't update with hot reload +8. Add the following line to your `gradle.properties` file: [example](https://github.com/flutter-stripe/flutter_stripe/blob/master/example/android/gradle.properties) +```properties +android.enableR8.fullMode=false +``` +This will prevent crashes with the Stripe SDK on Android (see [issue](https://github.com/flutter-stripe/flutter_stripe/issues/1909)). + +9. Rebuild the app, as the above changes don't update with hot reload These changes are needed because the Android Stripe SDK requires the use of the AppCompat theme for their UI components and the Support Fragment Manager for the Payment Sheets If you are having troubles to make this package to work on Android, join [this discussion](https://github.com/flutter-stripe/flutter_stripe/discussions/538) to get some support. -##### Issue with latest Android plugin - -We are aware of an issue with `com.android.application` plugin version 8.0.0 and above. Do not upgrade to this version as it can crash the payment sheet in release builds. See [issue](https://github.com/flutter-stripe/flutter_stripe/issues/1909) to follow the progress. - #### iOS Compatible with apps targeting iOS 13 or above. @@ -85,8 +87,7 @@ For card scanning add the following to your Info.plist: ```xml NSCameraUsageDescription Scan your card to add it automatically -NSCameraUsageDescription -<string>To scan cards</string> +NSCameraUsageDescription To scan cards ```