MapboxMapController requestMyLocationLatLng implementation missing

[loxodrome21]

Hi,

There used to be an implementation of the method requestMyLocationLatLng in lib/src/controller.dart:

Future<LatLng> requestMyLocationLatLng() async {
    try {
      final Map<Object, Object> reply = await _channel.invokeMethod(
          'locationComponent#getLastLocation', null);
      double latitude = 0.0, longitude = 0.0;
      if (reply.containsKey("latitude") && reply["latitude"] != null) {
        latitude = double.parse(reply["latitude"].toString());
      }
      if (reply.containsKey("longitude") && reply["longitude"] != null) {
        longitude = double.parse(reply["longitude"].toString());
      }
      return LatLng(latitude, longitude);
    } on PlatformException catch (e) {
      return new Future.error(e);
    }
}

It was changed in this commit Web implementation (#223) to:

Future<LatLng> requestMyLocationLatLng() async {
    return MapboxGlPlatform.getInstance(_id).requestMyLocationLatLng();
}

which is not yet implemented in lib/src/mapbox_gl_platform_interface.dart:

Future<LatLng> requestMyLocationLatLng() async {
    throw UnimplementedError( 'requestMyLocationLatLng() has not been implemented.');
}

Is there any workaround or plugin implementing this function? I am interested in iOS and Android implementations.

Thanks,
Carlos

[m0nac0]

@loxodrome21 Hi,
the lib/src/mapbox_gl_platform_interface.dart is actually just an abstract interface, the implementation we are using for android and iOS lives in mapbox_gl_platform_interface/lib/src/method_channel_mapbox_gl.dart.
That contains the following code: https://github.com/tobrun/flutter-mapbox-gl/blob/10788a7224ae8edd191bcef68e49d03e194c1058/mapbox_gl_platform_interface/lib/src/method_channel_mapbox_gl.dart#L356-L371
Have you tested requestMyLocationLatLng() on Android and iOS and do they actually throw an UnimplementedError?

[AAverin]

@m0nac0 in the linked ticket #405 you can also see that getLastLocation seems to be missing on iOS, this is probably related?

[AAverin]

At the moment 'locationComponent#getLastLocation' implementation is not present in MapboxMapController.swift

[AAverin]

Thought it would be easy to just grab location from mapView?.userLocation?.location, but it delivers lat=0, lon=0 even though user location is displayed on the map and permission is there. Would be great if someone with more iOS experience could take a look.

[leeprobert]

Did you ever resolve this issue? I am still getting this error on MapboxMapController.requestMyLocationLatLng - getLastLocation is not implemented.

[AAverin]

There is no "resolution". Somebody with the knowledge of how iOS work needs to implement method 'locationComponent#getLastLocation' and make a pull request.

[leeprobert]

Ok. I might be able to do this. I will need to if it is preventing any way of showing the user location in my Flutter app. Will get back to you.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[m0nac0]

Seems to still be relevant.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[AAverin]

Still missing, contribution from iOS devs is needed here.

[felix-ht]

I actually thing that i would be better to just deprecate this function and let users use some external package

[AAverin]

I also had this thought. We could also use some external package internally to build this functionality into the library.
But the map would need to update location indicator somehow too and this location stuff is already implemented by the native libraries anyways.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.