Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds Tool Changer controls #1111

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

pedrolamas
Copy link
Member

@pedrolamas pedrolamas commented Jun 18, 2023

Adds new Tool Changer controls that will execute the T0...Tn macros.

Colors can be set be adding a variable_color: "XXXXXX" (ommit the #) to each of the macros - thus matching the existing Mainsail behavior.

Wide

image

Mobile

image

Resolves #1110

@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Jun 18, 2023
@pedrolamas pedrolamas added this to the 1.24.2 milestone Jun 18, 2023
@pedrolamas pedrolamas requested a review from matmen June 18, 2023 13:53
@pedrolamas pedrolamas merged commit a7509e7 into fluidd-core:develop Jun 22, 2023
3 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/tool-changer branch June 22, 2023 15:44
@ningpj
Copy link

ningpj commented Jul 15, 2024

Has this feature been regressed in Fluidd v1.30.1? I have the following macros set but no longer see the T0...T button colors applied in the Fluidd UI and have verified I only have one set of T0...T11 macros loaded in Klipper (Tested with MS Edge & Safari in MacOS).

[gcode_macro T0]
variable_color: "111111" 
gcode: MMU_CHANGE_TOOL TOOL=0
[gcode_macro T1]
variable_color: "0000FF"
gcode: MMU_CHANGE_TOOL TOOL=1
[gcode_macro T2]
variable_color: "FF0000"
gcode: MMU_CHANGE_TOOL TOOL=2
[gcode_macro T3]
variable_color: "545454" 
gcode: MMU_CHANGE_TOOL TOOL=3
[gcode_macro T4]
variable_color: "E1Ad01" 
gcode: MMU_CHANGE_TOOL TOOL=4
[gcode_macro T5]
variable_color: "F8F0E3"
gcode: MMU_CHANGE_TOOL TOOL=5
[gcode_macro T6]
variable_color: "33FF33"
gcode: MMU_CHANGE_TOOL TOOL=6
[gcode_macro T7]
variable_color: "FF8C19"
gcode: MMU_CHANGE_TOOL TOOL=7
[gcode_macro T8]
gcode: MMU_CHANGE_TOOL TOOL=8
[gcode_macro T9]
gcode: MMU_CHANGE_TOOL TOOL=9
[gcode_macro T10]
gcode: MMU_CHANGE_TOOL TOOL=10
[gcode_macro T11]
gcode: MMU_CHANGE_TOOL TOOL=11 

@pedrolamas
Copy link
Member Author

Has this feature been regressed in Fluidd v1.30.1? I have the following macros set but no longer see the T0...T button colors applied in the Fluidd UI and have verified I only have one set of T0...T11 macros loaded in Klipper (Tested with MS Edge & Safari in MacOS).

Should be ok, in fact I just copy-pasted your macros directly to my Klipper config and it worked fine!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ERCF dashboard status display and controls
2 participants